GithubHelp home page GithubHelp logo

Clean QUazip reference about fastqt HOT 4 CLOSED

labsquare avatar labsquare commented on September 24, 2024
Clean QUazip reference

from fastqt.

Comments (4)

natir avatar natir commented on September 24, 2024

Ok the reference of QuaZip can be found in :

quazip class is just dead code we can remove it.

Comment in analysisrunner say it's possible the FastqReader::percentComplet function can return 0. But in implementation we see this function return 0 just when file is empty.
Maybe we can check if file is empty early and remove this comment.

@dridk did you have opinion about this point ?

from fastqt.

dridk avatar dridk commented on September 24, 2024

you can remove everything.
At the end, the method to compute percent will probably change.
Actually the problem is I don't know the totalSize of a compress file. I have to read the whole file one time before starting analysis.
@Arkanosis suggest me to get a percent progression directly from compressed bloc . .But I don't know how.

from fastqt.

Arkanosis avatar Arkanosis commented on September 24, 2024

I'll rewrite this to avoid decompressing files twice (I'm pretty sure more time is spent currently decompressing compared to actually computing the statistics). Feel free to clean up, though, as I'm not sure when I'll do this.

from fastqt.

dridk avatar dridk commented on September 24, 2024

Not relevant to this issue. See #38

from fastqt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.