nested resources and named params problem about echo

[fundon]

Maybe need a recursion function likes printTree.

[vishr]

This test doesn't do much, I am working on to add conflicting routes and priority order to get picked up - it's not done yet. I am not even sure if that would be possible without giving up on the performance of the router. #16

[fundon]

I'm looking forward. 👍

[fundon]

Do you have plain to fix this?

[vishr]

Deferred it until few more releases - it's getting complicated.

[fundon]

Okay, I also try to fix this in my Node version.
There are some cases http://guides.rubyonrails.org/routing.html.
I think we should support them.

[vishr]

Sure, thanks.

[fundon]

I think we can convert any :param to :$1 first, below like this:

/photos/:id => /photos/:$1
// alias = ['id']
/photos/:pid/users/:id => /photos/:$1/users/:$2
// alias = ['pid', 'id']

Convert the original path to format path and store the param keys.

[vishr]

@fundon This is an interesting point, I never noticed it. I will implement it at next opportunity.

[fundon]

@vishr I implement a version, and haven't been optimized, so currently it's very slower.

See

• https://github.com/trekjs/router/blob/refoctor/src/router.js
• https://github.com/trekjs/router/blob/refoctor/test/router.test.js test case
• https://travis-ci.org/trekjs/router/builds/

[fundon]

@vishr I refactor the add(), insert() and find() methods.
See

• https://github.com/trekjs/router/blob/master/src/router.js#L86
• https://github.com/trekjs/router/blob/master/src/router.js#L142
• https://github.com/trekjs/router/blob/master/src/router.js#L211

Convert paths to special format.

/:username/:repo/issues/:id => /:$0/:$1/issues/:$2

e.g:

• /users/:id => /users/:$0
• /users/:userId/photos/:id => /users/:$0/photos/:$1
• /users/:uid/books/:bid => /users/:$0/books/:$

Note Make sure the param node append to the end of the edges.

Improve performance.

I found the has key is unused in find method.

find(method, path)

steps:

1. search snode
2. search pnode
3. search cnode

Maybe I can submit a PR. hah

Example:

'/geocoder'
'/geocoder/new'
'/geocoder/edit'
'/geocoder/edit/email'
'/geocoder/edit/:item'
'/geocoder/any*'
'/geocoder/:action'

└── /geocoder has=1 h=function edges=1
    └── / has=0 h=null edges=4
        ├── edit has=1 h=function edges=1
        │   └── / has=0 h=null edges=2
        │       ├── email has=1 h=function edges=0
        │       └── :$0 has=0 h=function edges=0
        ├── new has=1 h=function edges=0
        ├── any has=3 h=null edges=1
        │   └── * has=0 h=function edges=0
        └── :$0 has=0 h=function edges=0

[vishr]

@fundon Great!
Has property gives us node information without looking up into findEdge function. Are you talking about improvement in the mentioned cases or in general - the current implementation of the router?

Also can you elaborate on what all features you have implemented so far in your router?

[fundon]

@vishr

Implemented features:

• Convert param key to special key, likes: /:username/:repo/issues/:id => /:$0/:$1/issues/:$2
• named param multi aliases, likes: /users/:id , /users/:userId/photos/:id => /users/:$0, /users/:$0/photos/:$1

Full cases https://github.com/trekjs/router/blob/master/test/router.test.js

[vishr]

@fundon Excellent, I never realized it was just a step away. I would like to incorporate these changes into the router - I already did some. How do you compare your router to other nodejs routers? Have you done any comparison?

[fundon]

Use GitHub API routes, compare with below:

• path-to-regexp
• route-recognizer
• route-trie
• routington

https://github.com/trekjs/router/blob/master/benchmarks/index.js

[fundon]

@vishr See this https://travis-ci.org/trekjs/router#L710

[vishr]

Cool, you should publish your results in nodejs forum, https://www.reddit.com/r/node etc.

[fundon]

Yes, I should. haha
Looking forward to your implementation in Go.

[fundon]

BTW, I do not use has key in find method, maybe it is not needed。

[vishr]

Yup, I am gonna take some time and refactor the router based on our discussion - that will cover the cleanup and other goodies ;)

[fundon]

@vishr I fixed a bug.

You can see this change via: https://github.com/trekjs/router/compare/d702c01826771302156a5e949bdc66a75992d431...master?diff=unified&name=master

[vishr]

#16

[fundon]

@vishr

The bug is below:

Bug:

/users/:id
/users/:id/edit

r.find('/users') // will match `/users/:id`.

The right behavior is not found.
It's fixed in my latest Node.js version.

[vishr]

I will look into it. Can you try the below routes?

/users/new
/users/:id

Find /users/nnn

[fundon]

I did not try that.

[vishr]

Wouldn't it go to new? as n comes first in the search?

[fundon]

Should match /users/:id.

[vishr]

@fundon I tried below code, it returns empty.

var Router = require('trek-router');

r = new Router()

// static route
r.add('GET', '/users/new', {});
// param route
r.add('GET', '/users/:id', {});
// catch-all route
r.add('GET', '/books/*', {});

result = r.find('GET', '/users/nnn')
console.log(result)

[fundon]

Yes, it's a bug. I'm thinking. How to fix this?

[vishr]

I need some time to fix it.

[fundon]

Me too. Good catch! Hah

[fundon]

Wow, nice! 👍

There is not goto statement in JavaScript. 😭 hah

[fundon]

@vishr I tried the latest Echo, I found a small bug.

/users
/users/new
/users/:id/echo
/users/*

Find /users/echo/hello => empty // right, return /users/*
Find /users/echo => empty // right, return /users/*

[vishr]

@fundon How have you implemented param name alias?
Thanks

[fundon]

@vishr Yes, I implemented it.

https://github.com/trekjs/router/blob/master/src/router.js#L87-L121

Examples:

/users/:id/echo => /users/:/echo ['id']
/users/:user_id/photos/:id => /users/:/photos/: ['user_id', 'id']

[vishr]

Thanks @fundon