GithubHelp home page GithubHelp logo

Comments (8)

Consolatis avatar Consolatis commented on September 26, 2024 1

hm.. you are right. We do not update the layershell background layer for new exclusive zones.
This has to be fixed. Thanks for the report!

from labwc.

Consolatis avatar Consolatis commented on September 26, 2024

Labwc does support layershell exclusive zones. But labwc does not prevent windows to be on top of it / under it when manually positioned. We do prevent automatically calculated geometry like maximized / tiled windows to overlap the exclusive zone however. How exactly is the "desktop background with icons" positioned and sized / does it use layershell as well?

from labwc.

spl237 avatar spl237 commented on September 26, 2024

The desktop is a layer-shell window which is anchored to all four edges of the screen and set to the background layer; the panel is a layer-shell window which is anchored to either the top or bottom of the screen and with exclusive zone set.

from labwc.

Consolatis avatar Consolatis commented on September 26, 2024

Just found this in the wlroots sources:

// If the exclusive zone is set to -1, the layer surface will use the
// full area of the output, otherwise it is constrained to the
// remaining usable area.

swaybg for example sets it to -1 which results in not reacting to exclusive zone clients.

There is also an issue in labwc in that we calculate the usable area starting from bottom layer to overlay layer so that even with manually hacking wlroots to always use the usable area it would still not work for non-exclusive background layers with exclusive bottom or top layer clients.

The following PR should fix the issue:

Testing welcome.

from labwc.

spl237 avatar spl237 commented on September 26, 2024

Tested here - fixes my problem! Many thanks for the very prompt fix.

from labwc.

Consolatis avatar Consolatis commented on September 26, 2024

Thanks for testing. We have a no-self-merge policy (unless its a crash fix or some minor stuff) so it might take a bit to have the fix in the master branch.

from labwc.

spl237 avatar spl237 commented on September 26, 2024

No problem at all - we're not in any hurry!

Thanks again.

from labwc.

spl237 avatar spl237 commented on September 26, 2024

Closing as patch fixes the issue.

from labwc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.