virtual keyboard (wlrctl keyboard) weirdness: letters 'y' and 'z' getting dropped about labwc

[jonleivent]

Any idea what commit brought this on?

No idea. I would expect that it's lower level - maybe down in wlroots. I wouldn't think labwc would have any code that could do something like this. So to speed up bisecting, maybe try right before and after you up the wlroots version?

Remember that I was previously stuck on the multisock branch, which is 0.6.4 based, prior to trying 0.7.0. I haven't checked in between.

[jonleivent]

Just tried the fix, and it works. Thanks!
Now, if only I had a workaround for #1366...

[johanmalm]

I can re-produce. How weird.
Any idea what commit brought this on?
If not, I'll try to do some bisecting.

[Narrat]

Took the liberty. Needs confirmation from someone, as I could have made a mixup.
But this did appear in the labwc 0.6.x releases, that I'm sure

5a77a3ad5176b09ff8576b8a6d05e53bcb4302d1 is the first bad commit
commit 5a77a3ad5176b09ff8576b8a6d05e53bcb4302d1
Author: John Lindgren <[email protected]>
Date:   Fri Nov 10 22:00:04 2023 -0500

    keyboard: remove nr_pressed_keys == 1 restriction for keybindings
    
    This restriction should be unnecessary now (see the previous commit for
    details) and caused issues with keybindings not working on some systems
    where irregular keypress events are received (e.g. XF86XK_WakeUp)
    without an accompanying release event.
    
    Kept separate from the previous commit for the sake of potential future
    bisects.
    
    Partially reverts e77330bc3fe7.

 src/input/keyboard.c | 13 -------------
 1 file changed, 13 deletions(-)

Edit: The log:

$ git bisect log 
# bad: [eb41fb1e0b510e623ab9fb91f697209effe8915b] build: bump version to 0.7.0
# good: [6b83db34afca59686d36a458b527b71355680d48] build: bump version to 0.6.4
git bisect start '0.7.0' '0.6.4'
# good: [a047e4a4e309c04300d3d3a7fb12e78bf3139e88] xdg,xwayland: raise sub-view correctly relative to other sub-views
git bisect good a047e4a4e309c04300d3d3a7fb12e78bf3139e88
# skip: [404fabec92d2106f7810502a071f96f9e4b2d7c5] Chase wlroots: wlr_scene_surface_from_buffer renamed
git bisect skip 404fabec92d2106f7810502a071f96f9e4b2d7c5
# bad: [2734302fd2e2571102e075bb97738a952a46b856] keyboard: fix key repeat bug on surface focus change
git bisect bad 2734302fd2e2571102e075bb97738a952a46b856
# good: [67a8ae8561dd1e92c8c850d19000320d8e74f0e3] Move input related source files into src/input/
git bisect good 67a8ae8561dd1e92c8c850d19000320d8e74f0e3
# good: [29a228674bc47720fc0a0e35fbb478d1cae8b66d] Add unfocus action
git bisect good 29a228674bc47720fc0a0e35fbb478d1cae8b66d
# bad: [5a77a3ad5176b09ff8576b8a6d05e53bcb4302d1] keyboard: remove nr_pressed_keys == 1 restriction for keybindings
git bisect bad 5a77a3ad5176b09ff8576b8a6d05e53bcb4302d1
# good: [00ec29c834b7dfc319b9daa57dce8b512baf3e74] CI: run FreeBSD job on Ubuntu
git bisect good 00ec29c834b7dfc319b9daa57dce8b512baf3e74
# good: [0bd265600edc165b2a763c35c2e148ba93705b5d] CI: avoid heavy dependency in FreeBSD job
git bisect good 0bd265600edc165b2a763c35c2e148ba93705b5d
# good: [7571c4bed347c55f69ec1826da679c4aa9c84f18] keyboard: avoid stuck keys due to keybindings (alternate approach)
git bisect good 7571c4bed347c55f69ec1826da679c4aa9c84f18
# first bad commit: [5a77a3ad5176b09ff8576b8a6d05e53bcb4302d1] keyboard: remove nr_pressed_keys == 1 restriction for keybindings

And reverting 5a77a3ad5176b09ff8576b8a6d05e53bcb4302d1 does indeed fix the behaviour for me

[johanmalm]

Thanks for reporting. And @Narrat thanks for the analysis.

I think I solved it (#1376).

Testing welcome.