GithubHelp home page GithubHelp logo

crash on Kill action with xwayland views about labwc HOT 3 CLOSED

xi avatar xi commented on September 22, 2024
crash on Kill action with xwayland views

from labwc.

Comments (3)

Consolatis avatar Consolatis commented on September 22, 2024

Hrm, right. We just kill the pid of the wayland client which in this case is xwayland itself.

So there are two issues here:

  • get the right pid (pid of the unix connection to the wayland socket for wayland native clients or ->pid for xwayland ones)
  • figure out why labwc is crashing when xwayland is killed and fix that

from labwc.

Consolatis avatar Consolatis commented on September 22, 2024

Did look a bit more into this:

00:00:05.541 [../src/action.c:700] Sending SIGTERM to 2525860, we are 2525860

So we are not actually crashing, we just send a SIGTERM to ourselves.
This makes sense due to the way wlroots creates the xwayland connection: the fd that is used by xwayland to connect to labwc is created by socketpair() in wlroots, e.g. our own process.

I'll prepare a PR to fix this unless somebody else beats me to it.

from labwc.

xi avatar xi commented on September 22, 2024

Thanks for the quick fix!

from labwc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.