Comments (11)
Thank you for sharing. This is indeed weird as there is nothing that explicitly changes the name of the file, the only path modifications are stripping off the source root and prefixing any destination root.
I'll take a look at this today, what runner are you using?
from action-azureblobupload.
Latest Ubuntu
from action-azureblobupload.
@LanceMcCarthy I chose to implement the upload using a different method back then. Bit swamped and the workflow works now so no offense if I don't get a chance to go back and test it out ¯_(ツ)_/¯
from action-azureblobupload.
If you need to be up and running now, try the Docker-based Azure Blob upload action from Matthew Fisher https://github.com/marketplace/actions/azure-blob-storage-upload. The parameters are every similar to mine because the Azure SDK is the same for everyone.
In the meantime, I'll continue to test this.
Regarding the timestamp filename, that value seems to be coming from the environment variable CURRENT_DATESTAMP
in the workflow. I don't use that variable in the Action, so I have no idea how that could possible become the filename.
However, I do have an ideas about where the 'als' part is coming from. Do you have a previous folder name that ends in als
? For example, here's something I think make sense in the context
azblobupload/finals/filename.zip
The ../ in the source path is breaking the file path creation here
Action-AzureBlobUpload/src/main.ts
Lines 61 to 106 in 8ce3f6e
from action-azureblobupload.
I'm uploading the files as artifacts so my short term solution is to manually download & upload the files. Not ideal, but the workflow is only manually run so not a big issue.
The timestamp is part of the filename I'm passing into the action. The als may be coming from the word "fundamentals" which is one of the two things I'm masking in the OP of this issue... but there's another word used that didn't generate that... which is strange.
The reason for the ".."in the filename is because of the variable ${{ github.workspace }}
points to the cloned repo in the workspace. The location where the ZIP files are that I want to upload is parallel to that folder. If there was a way to get the value of the folder path for the root of the repo (and not the identical folder name one level down), I could use that... but can't figure how to get around that.
from action-azureblobupload.
The workspace is typically one level down from where the commands are run. So you should be able to just use:
source_folder: ..\azblobupload
Let me know how that goes.
from action-azureblobupload.
Also, I have This Prebuilt TypeScript Playground script that mimics the Action's work.
I use to test certain files paths to see what the outcome would look like without having to make a commit to GitHub, run the Action and wait for every tiny change
Put your string paths in these called out variables, run it and check out Logs pane
from action-azureblobupload.
I'm also running into this issue. I suspect leading and trailing slashes in sourceFolder
and localFilePath
has an effect on the resulting trimmedPath
. I tested in the TypeScript Playground (very useful!) and will submit a PR for review.
from action-azureblobupload.
Thank you, I will review it today and push out a new release.
from action-azureblobupload.
I have validated, built, test and released v1.8.3 to GitHub Actions Marketplace
- @jacwil Thank you for opening the PR,
- @andrewconnell Can you please let me know if you're seeing any problems after updating the workflow to use v1.8.3
If you'd like to see the specifics:
- Here is the GH Action build results (it also contains Test results) https://github.com/LanceMcCarthy/Action-AzureBlobUpload/actions/workflows/main_release.yml
- Here's the release page https://github.com/LanceMcCarthy/Action-AzureBlobUpload/releases/tag/v1.8.3
from action-azureblobupload.
@andrewconnell no offense taken! If you start a new project and need this again, I'm happy to help.
from action-azureblobupload.
Related Issues (14)
- Usage example should use v1.8.0 instead HOT 1
- Default recursive doesn't work HOT 3
- Uploaded file is missing HOT 4
- Truncated blob name HOT 5
- Flatens file structure - subfolders contents go to root HOT 3
- If no destination_folder specified, it creates one as "no name" and truncates the first character of the filename HOT 2
- No_Name Folder Created in Blob container HOT 2
- Using 1.6, now I am losing the last character of the filename HOT 2
- Skip blobs already present in destination? HOT 7
- retry handling? HOT 13
- Upgrade Action from node12 to node16
- Double Forward Slashes Persist
- Intermittent files missing in Azure Storage Blob after upload HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from action-azureblobupload.