GithubHelp home page GithubHelp logo

Comments (11)

carlio avatar carlio commented on July 17, 2024 8

Sorry that I have been absent for a while, I will try to get onto this in the next few days...

from prospector.

carlio avatar carlio commented on July 17, 2024 1

Hi there, thank you for the report, I will add it to my TODO list along with pylint-dev/pylint-django#405
to handle some small changes needed to support the pylint3 release

from prospector.

ryancausey avatar ryancausey commented on July 17, 2024 1

#658 seems like a reasonable workaround to get 3.12 support out the door, but I'm also not an expert in prospector or pyroma. Assuming there are other pyroma tests in the suite, there should be some confidence that it doesn't actually break prospector's integration with pyroma.

from prospector.

robertalexa avatar robertalexa commented on July 17, 2024 1

hey @carlio, any status update on this?

from prospector.

valeriupredoi avatar valeriupredoi commented on July 17, 2024

Good man, Carl! Cheers 🍺

from prospector.

ryancausey avatar ryancausey commented on July 17, 2024

Is there anything I can do to help resolve this? I'm still running into the issue originally noted in #651.

from prospector.

Pierre-Sassoulas avatar Pierre-Sassoulas commented on July 17, 2024

The pipeline is broken on main, there's a potential fix in #658, you can review that, or propose another approach. Then #645 is addressing this issue directly and could be merged after a rebase.

from prospector.

valeriupredoi avatar valeriupredoi commented on July 17, 2024

@ryancausey cheers, mate! That's what my take is too - also, one clue is that workaround in #658 is needed only for when tests run on Github Actions, local tests run fine without it - beats me what changes in the file that the test runs on GA, but I suspect that's just a minor change like a trailing white space or some newline char, that gets picked up by the pyroma test

from prospector.

ryancausey avatar ryancausey commented on July 17, 2024

#658 seems like a reasonable workaround to get 3.12 support out the door, but I'm also not an expert in prospector or pyroma. Assuming there are other pyroma tests in the suite, there should be some confidence that it doesn't actually break prospector's integration with pyroma.

@Pierre-Sassoulas was my review above of any use?

from prospector.

ryancausey avatar ryancausey commented on July 17, 2024

Anything more I can do to help move this along?

from prospector.

valeriupredoi avatar valeriupredoi commented on July 17, 2024

very happy to see you back @carlio - we was getting concerned 🍺

from prospector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.