GithubHelp home page GithubHelp logo

Comments (4)

 avatar commented on July 18, 2024

this is clearly a bug in couch potato - the fix you sent along would fix it. i'm just not sure if the double colon is a good thing in a url - maybe dashes would be better? pull requests appreciated. :)

from couch_potato.

svenfuchs avatar svenfuchs commented on July 18, 2024

The only URI validation service I can find seems to be broken (http://www.w3.org/2005/01/yacker/uploads/uri?lang=perl&text=http://foo.com/bar::baz&action=validate+text).

But http://labs.apache.org/webarch/uri/rfc/rfc3986.html#path as well as http://en.wikipedia.org/wiki/URI_scheme#Generic_syntax seem to suggest that colons are just as fine as any other char (except question mark and semicolon) in a path segment.

Also, Ruby's stdlib URI class seems to agree with that:

>> URI.encode("http://foo.com/bar:baz")
=> "http://foo.com/bar:baz"

Dashes obviously would work, too, although looking at the design doc id in couch_db i kinda like that the double colon immediately makes clear where this originates from (i.e. that it's a class name).

I'll send a pull request :)

from couch_potato.

langalex avatar langalex commented on July 18, 2024

fixed in 0.2.28

from couch_potato.

svenfuchs avatar svenfuchs commented on July 18, 2024

yay :)

from couch_potato.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.