GithubHelp home page GithubHelp logo

Comments (2)

kazjote avatar kazjote commented on June 19, 2024

I reimplemented callbacks in http://github.com/kazjote/couch_potato/commit/7ae9a51e0d836992df356fb259b3ae1f3824a09e using activemodel which provides if/unless functionality.

Whole testcase is unmodified (except for
spec/callbacks_spec.rb) and passes.

The code is much shorter and and will be even more if I modify specs to reflect new code base.

I think that there is no point in not using activemodel as dependency. Community put much effort in extracting activemodel and now it is really simple and awesome.

If you agree on accepting my changes I will change the specs too and make pull request.

from couch_potato.

langalex avatar langalex commented on June 19, 2024

great work. i'll pull this next week, when i have returned from traveling.

from couch_potato.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.