Comments (2)
I reimplemented callbacks in http://github.com/kazjote/couch_potato/commit/7ae9a51e0d836992df356fb259b3ae1f3824a09e using activemodel which provides if/unless functionality.
Whole testcase is unmodified (except for
spec/callbacks_spec.rb) and passes.
The code is much shorter and and will be even more if I modify specs to reflect new code base.
I think that there is no point in not using activemodel as dependency. Community put much effort in extracting activemodel and now it is really simple and awesome.
If you agree on accepting my changes I will change the specs too and make pull request.
from couch_potato.
great work. i'll pull this next week, when i have returned from traveling.
from couch_potato.
Related Issues (20)
- how update field HOT 3
- Change format of #attributes HOT 2
- Custom port for database HOT 3
- Date patch is affecting lograge timestamp gem HOT 12
- CouchPotato.database.load_document does not instantiate the correct class HOT 6
- CouchDB Authentication HOT 1
- CouchRest 2.0 HOT 3
- Merge 1.x branch into master HOT 1
- Return result object from db queries
- Mango Support
- improve query interface HOT 1
- add caching
- validatations don't use default context
- Better error message for mismatching property type for [String]
- document.reload should not read from cache
- New release?
- write conflicts not detected because of dirty tracking and race condition
- Does sync/replication work?
- Problem with listing all documents in a view HOT 2
- Couchdb timeout option HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from couch_potato.