belongsToMany Foreign UUID not working. about blueprint

[rcrosbourne]

This PR addresses the issue.

[jasonmccreary]

Could you pull from master and see if it work. A PR was recently merged that may address this...

[makzumi]

Thanks Jason, will give it a try and thanks for Blueprint!

[makzumi]

sorry, nope, it is still not working, just tried master. :(

[jasonmccreary]

Ok. @rcrosbourne is this something your PR might have fixed?

[makzumi]

I have found the issue (i think...) there's this method in the MigrationGenerator class that passes the type to the buildForeignKey method. BUT the type is hard coded, trying to figure out how to correct it:

[jasonmccreary]

You definitely aren't pulling from master as that code has changed. So it'd be good to ensure you have set your composer constraint to dev-master and run composer update.

Try again and see if it generates the "correct" code. Also, if not, disable use_constraints and see if it does (without the constraints of course).

[makzumi]

I switched to dev-master again, but I'm still seeing no uuid on the pivot tables, I still think it has to do with that hardcoded "id" in that method.

[makzumi]

UPDATE:
It worked with the use_constraints set to false:

[makzumi]

I guess I can use it like this, thanks so much @jasonmccreary

[jasonmccreary]

The other path should be supported.

@rcrosbourne, seems your PR missed the path for setting foreign UUID/ULID columns with constraints (i.e. use_constraints enabled). I'd appreciate if you could fix that path.

[rcrosbourne]

Yea I will take a look at it.

[funder7]

Any news about this?

[jasonmccreary]

Nope.

[funder7]

No plan to merge the #661?
It seems ready. It's not a big problem to edit migrations manually, but if it's fixed...

[jasonmccreary]

As noted on the PR, it has some changes requested and like 46 commits which it difficult to review/trust. I plan to give more time to Blueprint after the release of Laravel 11. However, until then I don't have the time to wade through this PR unless the author can clean it up a bit.

[funder7]

I understand, sorry I saw the commits, but didn't have time either to read all the comments. Anyway if this issue is easy to fix (I guess it is), would be opening a new PR just for it, be a solution?

[jasonmccreary]

I welcome any PRs. It's easier on the maintainer if the changes are concise, have a well explained PR description, and contain passing tests.