Quantity instantly creates payments about cashier-mollie

[sandervanhooft]

I've prepared a solution for the v1 release, planned for end of the month. 🤞

[MSnoeren]

The $processNow = true flag looks like a great idea. This way we can run the Cashier command, for example, daily and group payments per billable model, cutting costs. It will also support the anchor date feature which is is not yet implemented, but a fallback would be to run the Cashier command.

[sandervanhooft]

For clarity the flag will be named invoiceNow.

processNow set to false suggests that the quantity is not instantly updated. Which it is, it's only invoiced later.

[sandervanhooft]

Hi @MSnoeren ,

Have you checked in the Mollie dashboard that 10 payments were created? They should be all combined into a single OrderItem, not 10.

If it's 10 OrderItems, this would only occur on the first payment, on subsequent payments the scheduler will combine it into a single Order and payment. (Would still not be ok obviously!)

[MSnoeren]

Currently I'm triggering the updateQuantity function each time a customer adds or removes a product. This means it'll create a payment for every quantity change. Using updateQuantity makes sure the quantity is always the same as the amount of active products. The payment is instantly processed and sent to Mollie; my testing-dashboard confirms this. The user has a valid mandate.

The code for this behavior can be found at;

cashier-mollie/src/Subscription.php

Line 660 in 61a3f0b

$order->processPayment();

The updateQuantity function requests the restartCycleWithModifications function which then requests the order to be processed.

[sandervanhooft]

Perhaps we could add a default flag processNow = true?

[sandervanhooft]

Alternatively you could place a layer in between (Front-end JS?) to delay the update to the back-end, capturing all 10 updates in a single request.

[sandervanhooft]

What do you think, should processNow default to true or false?

Given your use case, I'm leaning towards false.

[MSnoeren]

I think it should be true, as the current behavior is also true. I'm switching a lot of quantities with small costs, so it's useful to me to cut the costs and push the payment into one large one, but I can imagine that other applications want to bill their customers immediately whenever they add, for example, another user at a higher cost.

[sandervanhooft]

Ok, we'll take that route for now.