GithubHelp home page GithubHelp logo

Comments (9)

sandervanhooft avatar sandervanhooft commented on April 28, 2024 1

Oh sorry

I meant orderId_app_name_snake_case.pdf

from cashier-mollie.

MSnoeren avatar MSnoeren commented on April 28, 2024 1

Yeah, looks great. Filenames will be unique and traceable.

from cashier-mollie.

sandervanhooft avatar sandervanhooft commented on April 28, 2024

I agree @MSnoeren that the automatically generated invoice reference (id) would be a better default.

Perhaps we could bind an InvoiceFilenameGenerator into the container with this behaviour?

It could take the Invoice object as input.

from cashier-mollie.

MSnoeren avatar MSnoeren commented on April 28, 2024

Yeah, that would be great. If neccesary, others can create a custom class to generate their own filenames.

from cashier-mollie.

sandervanhooft avatar sandervanhooft commented on April 28, 2024

How about this for default: YYY-MM-DD-app_name_snake_case.pdf?

from cashier-mollie.

sandervanhooft avatar sandervanhooft commented on April 28, 2024

Putting it on my list. Feel free to submit a PR, otherwise I'll pick it up whenever I find the time.

from cashier-mollie.

Mindexperiment avatar Mindexperiment commented on April 28, 2024

Hi guys,
I'm going to use mollie with cashier package and can help on enhancements if needed.

Here in italy we organize phisical invoice archives by a number (called protocol, similar to invoice number) but when we needs to manage digital invoices a common patters is:

yyyymmdd_invnumber.pdf

Is unclear what app_name is for? if you refer to config('app.name') this can be userd by company with more than one department or for invoices downloaded by customer then you can simply:

yyyymmdd_invnumber_appname.pdf

from cashier-mollie.

sandervanhooft avatar sandervanhooft commented on April 28, 2024

Thanks @Mindexperiment,

The app name indeed refers to the config app name. Invoices tend to end up in a customer’s download folder, appending the app name will make it more readable there.

from cashier-mollie.

sandervanhooft avatar sandervanhooft commented on April 28, 2024

I have prepared this for the v1 release. The separate filename generator is not yet included. Feel free to send in a PR for that.

from cashier-mollie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.