Unable to get trialEndsAt date without payment up front after trial expired about cashier-paddle

[yoeriboven]

You'd probably want it to always return the value of trial_ends_at on the customers table if it is set.

There's one edge case however. What if you also (at a later stage) set a trial on the subscription model. In that case it should return the newest value. This seems very uncommon though.

I'll implement the first option later. If the maintainers want the second option, let me know. :)

[RobertBoes]

Yes, the user is no longer onGenericTrial, because the trial has ended, that makes sense.

I think onGenericTrial should not be used to get the trial_ends_at value. Maybe the method should become something like this:

public function trialEndsAt($name = 'default')
{
    if (is_null($this->subscription($name))) {
        return $this->customer->trial_ends_at;
    }

    return $this->subscription($name)->trial_ends_at;
}

This way the trial_ends_at of the customer is returned when the user has no subscription. But, this probably has other implications, because the customer might not exist.

[yoeriboven]

I don't think that would be a problem.

If you don't have either a customer or a subscription you shouldn't call this method anyway.

I proposed a fix with #87. Thanks for creating the issue.