updateDefaultPaymentMethod() should update subscription's default payment method about cashier-stripe

[driesvints]

Hi there. The current behaviour is the wanted one imo. I don't think that changing the default payment method on the customer should update the payment method on all of the existing subscriptions. We could add a new method on the subscription model maybe to update that payment method as well but I don't think that the current updateDefaultPaymentMethod method should automatically change the PM for a subscription as those are two separate concerns.

[FrozenGod]

Hi @driesvints

I don't really know what is the default payment method used for. Stripe sets the default payment method on the subscription by default, which always overrides the default payment method of the customer.

Maybe I'm not aware of the various use cases but for subscriptions I really can't come up with a way to have any use in the Customer's default payment method.

I think it's not the best approach by Stripe in the first place. I understand Cashier is just a wrapper on an existing API and I agree that Cashier should at least have an additional method for changing Subscription's payment method.

It was easy to create an event handler with:

$subscription = $billable->subscription();
        $subscription->updateStripeSubscription([
            'default_payment_method' => $newPaymentMethodId,
        ]);

But the time it took me to debug and research why my default payment method is not charged by default is definitely a huge waste of time, especially for people who use Cashier and/or Stripe API for the first time.