AttemptToAuthenticate is not throwing validation exceptions by default about fortify

[driesvints]

We're gonna look into that eventually but definitely feel free to send in a PR if you'd like.

[driesvints]

I think this is fixed with #127. Can you confirm that you have disabled 2FA? And try the changes from the PR? I'll tag those in a bit.

[sebdesign]

@driesvints will check now

[sebdesign]

@driesvints I can confirm that with disabled 2FA, the RedirectIfTwoFactorAuthenticatable action is not executed. Which solves the issue for failed non-2FA login attempts.

However, If I enable 2FA, I need to override/extend RedirectIfTwoFactorAuthenticatable in order to customize the
error bag on the ValidationException, because this action does it own validation.

But if the user doesn't have a two_factor_secret and does not use the TwoFactorAuthenticatable trait, the AttemptToAuthenticate action will be executed next, and the credentials will be validated once again.

I don't know if that's important, but that leads to a duplicate query to validate/fetch the user.

[driesvints]

What prevents you from overriding RedirectIfTwoFactorAuthenticatable?

[sebdesign]

I don't mind overriding it, since there's nothing that prevents me to do so.

What bugs me is that I have to do the exact change twice, because the credentials validation is kicking in twice, and there's also the "issue" of the duplicate queries:

(1) Handle `RedirectIfTwoFactorAuthenticatable`
(2) Validate credentials (first query)
    (3a) Throw exception if (2) fails
    (3b) Otherwise, check `two_factor_secret` and `TwoFactorAuthenticatable`
        (4a) If both are true, return the challange response
        (4b) Otherwise, handle `AttemptToAuthenticate `
            (5) Attempt to authenticate again (same query as (2))
                (6a) If login succeeded, handle `PrepareAuthenticatedSession`
                (6b) Otherwise, throw `ValidationException` like (3a)

[driesvints]

I'm going to close this one already since the only issue is a duplicate query which I don't consider a huge problem.