GithubHelp home page GithubHelp logo

Comments (13)

olafnorge avatar olafnorge commented on May 14, 2024 2

For me it's because of using the LTS but socialite v4 would force me to bump the full stack to at least laravel 5.7 which I don't really want to.

from socialite.

driesvints avatar driesvints commented on May 14, 2024 1

@kennith since we don't support 3.0 anymore probably not

from socialite.

kidager avatar kidager commented on May 14, 2024 1

@kennith since we don't support 3.0 anymore probably not

@driesvints I don't understand, if Laravel 5.5 is LTS (and is still supported) and it uses Socialite ^3.0, shouldn't it still be supported too ? If not what's the point of it being an LTS version if used laravel libraries aren't.

Following that logic, someone creating a fresh laravel project using version 5.5 (I'm totally against, but it is still supported) will not be able to install a working version of Socialite, v4 requires Laravel 5.7, and v3 isn't supported anymore!

from socialite.

iamacarpet avatar iamacarpet commented on May 14, 2024 1

@kidager LTS only applies for the framework and not the other libraries.

@driesvints don't you think this is why people think PHP for the enterprise is a joke?

It's only a 30 seconds job to do a release on GitHub so it gets picked up automatically by composer, with no negative impacts for anyone else, not like people are asking the earth here - it would have taken less time to just do it than reply twice. Why bother accepting the PR if you won't bother with a release?

from socialite.

driesvints avatar driesvints commented on May 14, 2024 1

@kidager we merged the pr and you can require it with Composer by requiring 3.0.x-dev like I said above.

from socialite.

dionmes avatar dionmes commented on May 14, 2024

Same here, still on 5.5 because of the LTS. I also got the email from Google that 'plus.people.get' method is being called and its deprecated.

from socialite.

driesvints avatar driesvints commented on May 14, 2024

Pr got merged. You can pull in 3.0.x-dev if you like.

from socialite.

kennith avatar kennith commented on May 14, 2024

@driesvints Thanks. Do you know if the merged PR will be released under 3.2.1?

from socialite.

driesvints avatar driesvints commented on May 14, 2024

@kidager LTS only applies for the framework and not the other libraries.

from socialite.

GrahamCampbell avatar GrahamCampbell commented on May 14, 2024

don't you think this is why people think PHP for the enterprise is a joke?

PHP has one of the best package ecosystems of any language actually, so I disagree.

from socialite.

kidager avatar kidager commented on May 14, 2024

PHP has one of the best package ecosystems of any language actually, so I disagree.

I totally agree with you there. But this is going to be a critical bug for every Socialite user managing a Laravel installation of v5.6 or less (Keeping always in mind that 5.5 is still supported and that laravel/socialite is part of laravel, not included by default, but still a part of the laravel ecosystem)

So seeing that a simple fix won't be applied for a library we're using in prod does not make me want to use it anymore! Even with the newer versions.

And we all agree here that a fix on the application part (a hack for short) is not something complicated, it's enough to replace the class in the container. But that's not the point, the point is the PR is accepted but won't be applied which ignores totally the users base need. No one will reference a "dev" version in their prod environment.

from socialite.

kidager avatar kidager commented on May 14, 2024

@kidager we merged the pr and you can require it with Composer by requiring 3.0.x-dev like I said above.

No one will reference a "dev" version in their prod environment.

from socialite.

driesvints avatar driesvints commented on May 14, 2024

Honestly, if all you're going to do is complain it's best that we just lock this.

from socialite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.