Comments (13)
For me it's because of using the LTS but socialite v4 would force me to bump the full stack to at least laravel 5.7 which I don't really want to.
from socialite.
@kennith since we don't support 3.0 anymore probably not
from socialite.
@kennith since we don't support 3.0 anymore probably not
@driesvints I don't understand, if Laravel 5.5 is LTS (and is still supported) and it uses Socialite ^3.0
, shouldn't it still be supported too ? If not what's the point of it being an LTS version if used laravel libraries aren't.
Following that logic, someone creating a fresh laravel project using version 5.5 (I'm totally against, but it is still supported) will not be able to install a working version of Socialite, v4 requires Laravel 5.7, and v3 isn't supported anymore!
from socialite.
@kidager LTS only applies for the framework and not the other libraries.
@driesvints don't you think this is why people think PHP for the enterprise is a joke?
It's only a 30 seconds job to do a release on GitHub so it gets picked up automatically by composer, with no negative impacts for anyone else, not like people are asking the earth here - it would have taken less time to just do it than reply twice. Why bother accepting the PR if you won't bother with a release?
from socialite.
@kidager we merged the pr and you can require it with Composer by requiring 3.0.x-dev
like I said above.
from socialite.
Same here, still on 5.5 because of the LTS. I also got the email from Google that 'plus.people.get' method is being called and its deprecated.
from socialite.
Pr got merged. You can pull in 3.0.x-dev
if you like.
from socialite.
@driesvints Thanks. Do you know if the merged PR will be released under 3.2.1?
from socialite.
@kidager LTS only applies for the framework and not the other libraries.
from socialite.
don't you think this is why people think PHP for the enterprise is a joke?
PHP has one of the best package ecosystems of any language actually, so I disagree.
from socialite.
PHP has one of the best package ecosystems of any language actually, so I disagree.
I totally agree with you there. But this is going to be a critical bug for every Socialite user managing a Laravel installation of v5.6 or less (Keeping always in mind that 5.5 is still supported and that laravel/socialite is part of laravel, not included by default, but still a part of the laravel ecosystem)
So seeing that a simple fix won't be applied for a library we're using in prod does not make me want to use it anymore! Even with the newer versions.
And we all agree here that a fix on the application part (a hack for short) is not something complicated, it's enough to replace the class in the container. But that's not the point, the point is the PR is accepted but won't be applied which ignores totally the users base need. No one will reference a "dev" version in their prod environment.
from socialite.
@kidager we merged the pr and you can require it with Composer by requiring
3.0.x-dev
like I said above.
No one will reference a "dev" version in their prod environment.
from socialite.
Honestly, if all you're going to do is complain it's best that we just lock this.
from socialite.
Related Issues (20)
- Linkedin provider: get user data HOT 2
- Linkedin provider: get user data HOT 7
- Page Isn't Redirect Properly Error In Github After Authorize Application HOT 1
- How can i make our customer to login with linkedin HOT 1
- sending wrong scope for linkedin HOT 2
- Exception on Linkedin: Undefined array key "storageSize" HOT 6
- [Linkedin] 'profile' and 'email' should be used as scopes[As Linkedin changed it] instead of 'r_liteprofile', 'r_emailaddress'.
- Profile URL HOT 1
- 5.11 release: PHP Fatal error: Declaration of SocialiteProviders\Okta\Provider::getRefreshTokenResponse(string $refreshToken) must be compatible with Laravel\Socialite\Two\AbstractProvider::getRefreshTokenResponse($refreshToken) HOT 1
- SocialiteProviders\Apple\Provider::refreshToken(string $refreshToken) compatibility problem HOT 1
- Trying to access array offset on value of type null HOT 1
- Can't get bot slack user and bot tokens HOT 7
- Refreshing access tokens does not work for Google HOT 3
- facebook API version question HOT 1
- GoogleProvider Type Error HOT 3
- GoogleProvider Not Receiving nickname Key HOT 3
- Issue authenticating HOT 3
- Bug with Microsoft ADFS after PR 684 HOT 3
- Sign In With LinkedIn Not working aymore? HOT 1
- Socialite installation will have the default packages removed HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from socialite.