Lumen compatibility about html

[jackmcdade]

Lumen's URLGenerator is missing some of the methods HTMLBuilder calls, like asset(), so that approach won't be perfect.

[adamgoose]

Thanks for the note Jack - that's exactly right. See here: LaravelCollective/docs@0cf2342

[jackmcdade]

@adamgoose While i agree with that statement in general, I think that in this situation those "core changes to Lumen" would be beneficial and are not by themselves reason enough to use Laravel or Lumen. Those changes are simply 3 small helper methods to write asset paths, something an API could certainly take advantage of.

In fact we're building Statamic 2.0 on Lumen because we literally don't need everything in Laravel. We don't need SwiftMailer, Eloquent, and a number of the other larger packages, and we need our own bootstrapping system. Lumen is perfect for us. We need need some of these features though, so I'm sending a PR on Lumen for those methods.

Just my 2 cents.

[adamgoose]

@taylorotwell and I have already discussed this. He does not want to implement those helper methods.

Sent from my iPhone

On May 21, 2015, at 12:05 PM, Jack McDade [email protected] wrote:

@adamgoose While i agree with that statement in general, I think that in this situation those "core changes to Lumen" would be beneficial and are not by themselves reason enough to use Laravel or Lumen. Those changes are simply 3 small helper methods to write asset paths, something an API could certainly take advantage of.

In fact we're building Statamic 2.0 on Lumen because we literally don't need everything in Laravel. We don't need SwiftMailer, Eloquent, and a number of the other larger packages, and we need our own bootstrapping system. Lumen is perfect for us. We need need some of these features though, so I'm sending a PR on Lumen for those methods.

Just my 2 cents.

—
Reply to this email directly or view it on GitHub.

[jackmcdade]

We had a chat and he changed his mind. It's fine if you don't want to support Lumen, but now you can if you want.

laravel/lumen-framework#111

[adamgoose]

Well there you have it... We'll re-evaluate!

[RobinMalfait]

@adamgoose I will be more active once my exams are over!

@jackmcdade nice to see you here and in email :)

[edandy]

No found to {!! HTML:: !!}

[vluzrmos]

I made a fork to implement changes to work on Lumen:
https://github.com/vluzrmos/collective-html

[tshafer]

I am going to look into supporting lumen next week.

[tshafer]

If someone wants to make a pull request, feel free. I wont be implementing this anytime soon, no time.