Providing a route name to Form::open does not automatically specify the _method for me about html

[adamgoose]

Sorry, but this isn't possible. Currently, and I do it frequently, one can use the same route name on two different HTTP methods. Thus, it's not possible to determine, with adequate certainty, which verb to use.

Close

Sent from my iPhone

On Sep 13, 2015, at 4:35 PM, Brett Taylor [email protected] wrote:

If I have the route:

Route::put('cart/add', ['as' => 'cart.add', 'uses' => 'CartController@addProduct']);
and in a view I have:

{!! Form::open(['route' => 'cart.add', 'class' => 'form-horizontal']) !!}
I expect the output:

But it does not create the _method hidden field. It should detect that the route is a PUT, and automatically output the _method hidden field.

Backwards compatibility shouldn't be an issue, as if people have named routes that aren't POST they're already creating their own _method field which will override the one Form::open would create.

Is this something that would be accepted as a pull request?

—
Reply to this email directly or view it on GitHub.

[Glutnix]

You use the same route name on two different methods: Are you sure you don't mean the URI fragments? It seems weird to have two named routes with the same name: what's the point?

[adamgoose]

Yes, I mean the same route name. I use the HTTP verb to differentiate. Whether you use this strategy or not, it's still impossible to ensure that it would resolve correctly.

Sent from my iPhone

On Sep 13, 2015, at 4:46 PM, Brett Taylor [email protected] wrote:

You use the same route name on two different methods: Are you sure you don't mean the URI fragments? It seems weird to have two named routes with the same name: what's the point?

—
Reply to this email directly or view it on GitHub.

[Glutnix]

Okay, thanks. Glad I asked before writing a PR :)

[adamgoose]

I appreciate the effort, though! Thanks for contributing. :)

[Glutnix]

Maybe I could clarify this in the documentation? Something along the lines of:

When using named routes be aware that Form::open will not inspect the route to determine the route's method. Be sure to specify the method yourself.