GithubHelp home page GithubHelp logo

Linkify links in comments about pullup HOT 7 CLOSED

larvalabs avatar larvalabs commented on August 27, 2024
Linkify links in comments

from pullup.

Comments (7)

vanev avatar vanev commented on August 27, 2024

URI.js would be awesome for this. I can throw together a pull request tonight unless someone beats me to it.

from pullup.

treygriffith avatar treygriffith commented on August 27, 2024

Also, what about a more general solution to text formatting in comments, like markdown?

from pullup.

josephwegner avatar josephwegner commented on August 27, 2024

+1 for markdown. But you'd probably want a modified parser rather than the generic ones - a lot of markdown elements don't make sense in a comment (h1-3, img)

from pullup.

 avatar commented on August 27, 2024

The marked lib. looks like a good fit -- the gfm option seems somehow appropriate -- and it allows you to directly override renderer methods.

from pullup.

vanev avatar vanev commented on August 27, 2024

@cgroner, took your advice on marked. It looks great.

Only concern with Jade is that you need to use != which drops raw HTML. That seems like a security thing.

from pullup.

kennethrapp avatar kennethrapp commented on August 27, 2024

Might be too late but why not leave markdown parsing to the browser? Then you can leave everything escaped however you want.

from pullup.

josephwegner avatar josephwegner commented on August 27, 2024

Markdown is in, which includes linking... Closing this.

from pullup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.