Comments (6)
megamattron
commented on July 24, 2024
Yes, totally agree. I've started closing PRs that are just username additions, and even some that are just code re-orgs. I think this is only going to work if people are contributing real code, even if they're bug fixes.
from pullup.
treygriffith
commented on July 24, 2024
Maybe we can add a doc (as part of the README and/or on the site) that outlines the requirements for a PR to be accepted.
from pullup.
megamattron
commented on July 24, 2024
Sounds like a good idea. Something around needing to add a feature, or fix a bug. Even if re-orgs or cleanups are needed it would be better if they were done by people who were already members, so best to focus first PRs on features and so on.
from pullup.
wle8300
commented on July 24, 2024
@megamattron, I contributed 2 bug fixes which were merged (#45, #46). Could you add me?
from pullup.
megamattron
commented on July 24, 2024
@williamle8300 sure, you should have access now. Thanks!
from pullup.
megamattron
commented on July 24, 2024
Closing this now as I've added contributing.md where we can compile requirements for easy reference by new users.
from pullup.
Related Issues (20)
- Footer is not anchored to the bottom of the page HOT 5
- Better mobile views HOT 1
- Consider having a goal to focus on. HOT 4
- Landing page still visible after login HOT 1
- Justify GitHub Auth permission to read/write my repositories HOT 6
- A new idea for PullUp HOT 16
- Help: Issue deploying to heroku HOT 2
- Autocomplete username in comments HOT 3
- Update README.md: no need to include quotes around env variables when exporting them HOT 1
- Pullup as a reddit style layer for pull requests and issues. HOT 8
- [RFC] Switch from Gitter to Slack
- [LINKS] Domain not parsed on this submission HOT 1
- [PROFILE] Add contributions to mobile
- Add margin between error message and join alert HOT 2
- Make comments linkable
- Submit News button is misaligned HOT 3
- Hide upvote button if already upvoted
- On mobile: Vertically center vote count when there's no upvote
- Comment deleting needs a backend check
- Help me
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pullup.