GithubHelp home page GithubHelp logo

Comments (4)

lathonez avatar lathonez commented on June 10, 2024

it means that vscode, which using tsconfig.json, won't report errors in test files

I have the same issue in webstorm, when I last looked there wasn't a way to direct the editor to use a specific config file. Unfortunately the best way I've found to work around this is to comment out the exclude when I'm not running the app.

I'm also using https://github.com/angelozerr/tslint-language-service and so linting isn't available in excluded files.

Sorry I don't know about tslint-language-service.

Is there a way to direct ionic to use a different tsconfig.json, similar to how ng cli has a tsconfig per-task?

Not to my knowledge, least not the last time I checked. Ionic are constantly improving their scripts, so this may have changed.

Alternatively, does it actually matter if these files aren't excluded?

There's a lot of history here.. #159 #167 #170 #174 #236

Here's the relevant comment where we finally added it back: #236 (comment)

So, it seems they are only there for ionic build --prod. I have run that locally and it works OK, so am going to remove them and see what breaks in CI / who complains about it.

from clicker.

lathonez avatar lathonez commented on June 10, 2024

So yea, it breaks on windows: https://ci.appveyor.com/project/lathonez/clicker/build/1.0.147

from clicker.

lathonez avatar lathonez commented on June 10, 2024

Added the Jasmine types back in, which fixed it previously on Windows

from clicker.

lathonez avatar lathonez commented on June 10, 2024

looks good.

So basically - you no longer need the excludes. If you are running windows you need to add jasmine types. Have never been able to figure out why these are not needed on linux based distro.

See recent commits, will update the blog.

Thanks

from clicker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.