Comments (4)
it means that vscode, which using tsconfig.json, won't report errors in test files
I have the same issue in webstorm, when I last looked there wasn't a way to direct the editor to use a specific config file. Unfortunately the best way I've found to work around this is to comment out the exclude when I'm not running the app.
I'm also using https://github.com/angelozerr/tslint-language-service and so linting isn't available in excluded files.
Sorry I don't know about tslint-language-service.
Is there a way to direct ionic to use a different tsconfig.json, similar to how ng cli has a tsconfig per-task?
Not to my knowledge, least not the last time I checked. Ionic are constantly improving their scripts, so this may have changed.
Alternatively, does it actually matter if these files aren't excluded?
There's a lot of history here.. #159 #167 #170 #174 #236
Here's the relevant comment where we finally added it back: #236 (comment)
So, it seems they are only there for ionic build --prod
. I have run that locally and it works OK, so am going to remove them and see what breaks in CI / who complains about it.
from clicker.
So yea, it breaks on windows: https://ci.appveyor.com/project/lathonez/clicker/build/1.0.147
from clicker.
Added the Jasmine types back in, which fixed it previously on Windows
from clicker.
looks good.
So basically - you no longer need the excludes. If you are running windows you need to add jasmine types. Have never been able to figure out why these are not needed on linux based distro.
See recent commits, will update the blog.
Thanks
from clicker.
Related Issues (20)
- Tests not running fully under PhantomJS HOT 2
- Protractor and lazy load tab pages HOT 1
- You need to include some adapter that implements __karma__.start method! HOT 8
- Add support for multiple languages HOT 4
- Ionic deeplinks HOT 3
- Feature modules HOT 6
- Update to latest HOT 1
- Update GIF HOT 1
- Deploy live version HOT 8
- Getting a '404' for -> http://lathonez.com/2017/ionic-2-unit-testing/ HOT 1
- Undesirable Warning: Critical dependency: the request of a dependency is an expression HOT 1
- Questions about E2E test cases for Ion-menu component HOT 1
- Error: Uncaught (in promise): invalid link: rootPage in case of lazy loading unit test cases HOT 1
- Usage of Greenkeeper HOT 1
- Help needed to manually trigger Swipe gesture on DIV in E2E tests HOT 3
- Question: Translation R to L Support HOT 1
- Setup insufficient to test apps dependent on external APIs
- when i compiling the ng serve it was display warning and uncompiling files
- Burh test
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clicker.