Comments (3)
If the key string you pass to PgAdvisoryLock
is constant, you could put it in a smol::lock::OnceCell
or a std::sync::LazyLock
inside a static
which would give you &'static
references to it.
We could probably promote with_key()
to a const fn
so that it can be constructed directly in a static
.
Otherwise, I'm not against .acquire_owned()
/.try_acquire_owned()
methods taking Arc<Self>
. There's no real reason it doesn't exist already besides "I didn't think of it".
Couple bikeshedding things:
- I'd prefer the
_owned
suffix to match Tokio: https://docs.rs/tokio/latest/tokio/sync/struct.RwLock.html#method.write_owned - It's a judgement call whether to take
Arc<Self>
or&Arc<Self>
. The latter would increment the reference count lazily for less thrashing on highly contended locks, but the former would allow even theacquire()
call itself to be moved into a task if desired.- I'm leaning toward
Arc<Self>
since it's strictly more flexible at the minor cost of requiring an explicit.clone()
. Thrashing the refcount doesn't really matter since it's going to be dwarfed by the network overhead anyway. It also matches Tokio's API.
- I'm leaning toward
from sqlx.
Unfortunately my keys are not constant. But I appreciate the idea.
I agree with your design thoughts.
I might have time to try implementing this feature if you're open to that.
from sqlx.
Yeah, I'd appreciate it!
from sqlx.
Related Issues (20)
- Replace `query_file*!()` variants with inherent support for `include_str!()` and other macros
- sqlx think medium text as binary? HOT 7
- Support versioned fixtures for ensuring that migrations preserve data correctly HOT 1
- Put the sqlx::MySqlPool to golbal static variable. Get `PoolTimedOut`, when exec sql. HOT 1
- `path` argument to `[sqlx::test]` broken in 0.8.0 HOT 3
- `sqlx database create` cannot create a database file for SQLite (0.8.0 regression) HOT 5
- Transaction meets E0521: borrowed data escapes outside of method HOT 5
- `query_as!` does not recognize `Option<T>` in some `left join` queries HOT 1
- `<uuid::fmt::Hyphenated as sqlx::Type<MySql>::compatible()` is wrong? HOT 1
- sqlx uses time instead of chrono HOT 9
- regarding the default behaviour SET sql_mode=(SELECT CONCAT(@@sql_mode, ',PIPES_AS_CONCAT,NO_ENGINE_SUBSTITUTION')),time_zone='+00:00',NAMES utf8mb4 COLLATE utf8 HOT 6
- bug: memory leak in `PgStream`
- `features = [ "tls-rustls-*" ]` is failing to build HOT 1
- Feature Request: Expose `transaction_depth` with a Read-Only Getter Method HOT 2
- Select of a hardcoded value returns Option<T> instead of just T HOT 1
- No autocommit on "RETURNING" clauses in sqlite HOT 2
- Migration from 0.7 to 0.8 chrono feature HOT 1
- relation "_sqlx_migrations" does not exist
- Potential vulnerability: overflowing and truncating casts HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sqlx.