GithubHelp home page GithubHelp logo

Add Scheduler trait/enum about diffusers-rs HOT 2 OPEN

rockerBOO avatar rockerBOO commented on May 30, 2024
Add Scheduler trait/enum

from diffusers-rs.

Comments (2)

mspronesti avatar mspronesti commented on May 30, 2024 1

A possibility to solve the timestep type issue Is to have inside the trait a type, say timestep_t which requires to be cloned, copied and allowed to be converted to a primitive type

type timestep_t = Copy + Clone + toPrimitive;

and then use it in the trait as Self::timestep_t. Therefore, when implementing the trait for a particular scheduler one only needs to set it appropriately

impl Scheduler for MyScheduler {
    type timestep_t = usize;
}

I did all of this already, but I'm waiting to open a PR because I have 2 more pending and one more soon to be opened implementing the Heun Discrete scheduler 😅

from diffusers-rs.

mspronesti avatar mspronesti commented on May 30, 2024

On second thought, I'm not so sure this is a good idea. Not if we want to port other diffusion models, at least. In fact, some of the missing schedulers have a different implementation logic: some don't implement add_noise, some others have two different kind of steps (the predictive step and the correct step, with different return types), e.g. the stochastic differential equation (SDE) scheduler.

from diffusers-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.