GithubHelp home page GithubHelp logo

Comments (5)

LaurentMazare avatar LaurentMazare commented on June 16, 2024

Sounds good! I feel that triggering it explicitly via an environment variable would be better to start with (the pre-built cuda binary will result in a large download). I think that only cuda 9.0 is supported for pre-built libtorch for now so TORCH_USE_CUDA sounds good to me.

from tch-rs.

mwilliammyers avatar mwilliammyers commented on June 16, 2024

I have it almost coded up using TORCH_CUDA_VERSION which checks for 9.0 or 90 and sets it to cu90, but I can also have it just check to see if that variable is set to anything and use cuda 9.0 so we can be forward compatible?

from tch-rs.

LaurentMazare avatar LaurentMazare commented on June 16, 2024

Asking for TORCH_CUDA_VERSION to be 9.0, 90 sounds reasonable. Maybe worth adding a comment at the top of say build.rs so that it's clear how to trigger this.

from tch-rs.

mwilliammyers avatar mwilliammyers commented on June 16, 2024

Ok, cool. Also, should we panic if you set TORCH_CUDA_VERSION on macOS or silently use cpu?

from tch-rs.

LaurentMazare avatar LaurentMazare commented on June 16, 2024

Let's panic with an appropriate error message in this case - that way things will be pretty explicit.

from tch-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.