Environment can be null about isolated-vm

[laverdet]

A stack trace would be helpful if you can provide it. The change 478815b was legit because without the assertion we otherwise would be dereferencing a null pointer. The assertion fails faster and louder.

[jpshack-at-palomar]

I believe I am seeing this w/ node 20.10.0 and isolated-vm 5.0.0 on linux but not MacOS. I have an exit hander that tries to clean up when the process ends. I get a clean exit on MacOS but on linux after all test has passed successfully at the very end I get: node: ../src/isolate/environment.h:202: static ivm::IsolateEnvironment& ivm::IsolateEnvironment::GetCurrent(): Assertion `environment != nullptr' failed and non zero exit code.

Happy to provide any additional information if you can tell me how to get it.

   static async initializeIsolate() {
        if (!EvalAction.isolate) {
            EvalAction.isolate = new ivm.Isolate();

            process.on('exit', (code) => {
                this.debug(`The process is terminating with with code: ${code}`);
                this.debug(`Disposing of VM isolate and context...`);
                if (EvalAction.isolate) {
                    try {
                        EvalAction.isolate.dispose();
                        EvalAction.isolate = null;
                        EvalAction.context = null;
                    } catch {
                        // no op
                        // tests are passing but in ci I see this error after the test suite has run:
                        // node: ../src/isolate/environment.h:202: 
                        // static ivm::IsolateEnvironment& ivm::IsolateEnvironment::GetCurrent(): 
                        // Assertion `environment != nullptr' failed.
                    }
                }

                this.debug('Cleanup complete.');
            });

            EvalAction.context = await EvalAction.isolate!.createContext();

            // Expose globals
            await EvalAction.initGlobals();

        }
    }