Comments (2)
We can't do window.location.href solution. If an other framework or user code is listening to the click event, this event won't be triggerd if we do a window.location.href. That is why the event is retriggered if layerjs can not handle it.
A solution might be to add an attribute to layerjs links. This way we only listen to layerjs links.
The downside is that users can not add click listeners to layerjs links, because there is no guarantee that these listeners will be triggered or if they will only be triggered 1 time.
from layerjs.
Can you try to preventDefault and NOT “stopPropagation” at first and then do a location.href at the end. do the location.href change in a setTimeout of 1ms to get behind all following listeners. That should always execute all click handlers but no activate the link handling by the browser. Then, the location href would not trigger any click handlers anymore.
from layerjs.
Related Issues (20)
- size is not adapted during transition
- scrolltransformer scroll event listeners registered multiple times?
- unhandled hash routes -> sets window.location.href
- enlarging frame is not detected (and scroll end is incorrect) HOT 1
- accessive number of lj-active classes added to active frame
- right swipe not working
- no-url option doesn’t seem to work for !none frame
- double loading of layers makes trouble
- scrollTo label does not work if label is not in current frame
- exception on special frame !right if neighbours.r not given
- back button problem in hashrouter HOT 1
- no-url state changes go into history
- Track touch for swipe/pan gestures HOT 1
- Anchor tag attribute target="{my value}" seems to be ignored HOT 4
- Your homepage fails to restore my Safari scrolling to top HOT 6
- Adapt page title when using filerouter HOT 1
- linking to anchors from external does not work
- lj-auto-height is set in stage, and the height of stage does not change automatically. HOT 1
- Layer JS site certificate is expired and other issues HOT 2
- CDN cert date invalid
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from layerjs.