GithubHelp home page GithubHelp logo

Comments (5)

layershifter avatar layershifter commented on August 26, 2024

@fivefilters Hi, thanks 😄

Yes, this can be uncommented and it will be the easiest solution. But as LibXML/PHP DOM doesn't have a special object for whitespaces i.e. DOMWhitespace it will produce too many unnessary DOMText's. This will break my production app.

However, whitespaces should be always created when they are inside the <pre> tag. I'm think that I will able to fix it on this week. The provided test case is very usefull.


I'm also want to deprecate this package when php-myhtml will be production ready. But it needs too many time because there are complicated problems with inheritance of internal DOM classes. I'm not sure that I will be able to find it in this year.

from gumbo-php.

fivefilters avatar fivefilters commented on August 26, 2024

@layershifter Thanks for the helpful reply! I'll wait for the fix. :)

Oh, and I didn't know about your myhtml extension for PHP. I'll be keeping an eye on that too.

from gumbo-php.

layershifter avatar layershifter commented on August 26, 2024

@fivefilters I've pushed recently d61c16b, as you can see your test case was simplified. There is still problem with handling of new lines, but it's everything that I can do right now.

I'm planning to solve similar issues in php-myhtml, but as I said this will not be soon.

from gumbo-php.

fivefilters avatar fivefilters commented on August 26, 2024

@layershifter Thank you! :)

from gumbo-php.

layershifter avatar layershifter commented on August 26, 2024

@fivefilters I know that you forked it, feel free to maintain it.

I'm working with frontend now and don't have enought time to work on it. I will archive this repo, if you have any questions - feel free to email me.

from gumbo-php.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.