GithubHelp home page GithubHelp logo

Comments (7)

lucdion avatar lucdion commented on May 15, 2024 1

Yes, you should layout your views either from UIView. layoutSubviews() or UIViewController.viewDidLayoutSubviews(). This way when the size of your parent view change your subviews layout will be adjusted. This will also handle device orientation change.

from pinlayout.

lucdion avatar lucdion commented on May 15, 2024

Hi @netgfx, aspectRatio (and all other PinLayout's methods) can be applied to any view that inherits from UIView.

PinLayout's don't use constraints, whenever you want to change the size/position of a view, you have to re-layout your view to update either its position, size or both.

from pinlayout.

netgfx avatar netgfx commented on May 15, 2024

So the flow would go like this: load video > get width&height > set dimensions to playerViewControler view > call view.layoutSubviews()
?

from pinlayout.

lucdion avatar lucdion commented on May 15, 2024

Sorry, I've never used the AVPlayerViewController, but most UIViewController inherited class comes with their own UIView (UITableViewController, UICollectionViewController, ...). So it is not really easily possible to control how they layout their view (and subviews), I'm surprise that it don't correctly handle its movie aspectRatio.

If you want to have more control you should probably use AVPlayer. See https://stackoverflow.com/a/31277658

from pinlayout.

netgfx avatar netgfx commented on May 15, 2024

Even in the example that you send it uses let playerViewController = AVPlayerViewController() to contain the AVPlayer which is the underlying player.

In terms of PinLayout I'm mostly interested on how to change width and height dynamically. Since I found that after the movie is loaded I can get its width and height via self.player.view.layer.visibleRect.width & self.player.view.layer.visibleRect.height

So is there away to dynamically change the .pin.height() of that self.player.view? (Initially I set it to .pin.height(50%)

from pinlayout.

lucdion avatar lucdion commented on May 15, 2024

You can use any PinLayout's sizing method https://github.com/mirego/PinLayout#width-height-and-size on any view, including the player.view.

You can also use the aspectRatio method to force the aspect ratio (https://github.com/mirego/PinLayout#aspect-ratio)

let movieAspectRatio = self.player.view.layer.visibleRect.width / self.player.view.layer.visibleRect.height
self.player.view.pin.width(100%).aspectRatio(movieAspectRatio)

from pinlayout.

netgfx avatar netgfx commented on May 15, 2024

ok good to know, that helps.

Can I call self.player.view.pin.width(100%).aspectRatio(movieAspectRatio) from any part in the class or does it have to be inside the layoutSubviews() function?

from pinlayout.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.