GithubHelp home page GithubHelp logo

Comments (2)

WoZ avatar WoZ commented on August 25, 2024

Btw, PR I've added brokes functional tests. That's because previously FramesMonitor received a full set of audio and video frames from the beginning of a mp4 test file (ffmpeg -listen 1 waits for incoming connection to start stream the file). That buffer helped to calculate video and audio frames.

If we add -fflags nobuffer first frame received by monitor may vary from platform to platform and from version to version of ffmpeg/ffprobe.

I see few solutions:

  • remove failing functional tests
  • replace failing test files with new ones and rely deeply on some frame, let say, at 5 sec from the beginning of file.

The second approach will work only when ffmpeg/ffprobe can determine metadata of the stream prior detection of "control" frame. Additionally, -probesize may help to prevent overflow but I think that this is bad idea to tune -probesize. I saw a lot of segfaults with incorrect values and probesize may cause false negative results.

Guys, what do you think? @fox-hellraiser @OlegPoberegets

from video-quality-tools.

fox-hellraiser avatar fox-hellraiser commented on August 25, 2024

@WoZ

remove failing functional tests

ff

from video-quality-tools.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.