useless gaps window misplacement about lain

[lcpz]

I tried every layout without being able to reproduce.

This is a screenshot.

Is this happening with all layouts or just some of them? Can you provide a screenshot?

[shmibs]

it's effecting every layout for me. maybe it's something related to window border width? i'm using two-pixel borders, and it looks like you're using only one.
screenshot

EDIT: i took another look at your screenshot, and the error IS occuring for you as well. your gaps are 11 pixels at the top and left and 9 at the bottom and right, so i guess the issue is definitely a window-border problem.

[lcpz]

Tell me if this is ok.

Gist [deleted]
Screenshot

[shmibs]

it's symmetrical, which is definitely better, but now you have an 11 pixel
gap between windows and ten on the edges instead of the other way around.
how does that behave when you have windows sandwiched in between (i.e. 3
windows tall in fair mode)?

EDIT: after looking at the problem again, i think the proper way to express this would be something like this (please excuse the pseudocode; i don't know the names of everything =P):

g.width = round( (screen.width - useless_gap * (screen.client_x_count+1))/screen.client_x_count )

where screen.client_x_count is the number of clients across the screen at that position. stuff gets really messy, though (particularly if trying to disclude window borders from the gaps, as that means variable gap widths too), so it might not even be worth it to try to fix this. i think i'm just going to use

g.width = g.width - useless_gap
g.x = g.x + math.ceil(useless_gap * .25)

[lcpz]

I didn't understand how to measure gaps the way you do (in my previous screenshot I observed 10 px everywere, border_width included).

But since these "distance attempts" may take forever, why don't you patch and test the layouts yourself?

g.width = round( (screen.width - useless_gap * (screen.client_x_count+1))/screen.client_x_count )

if I am not mistaken can be translated like this:

g.width = round( (p.workarea.width - useless_gap * (num_x + 1))/num_x )

where round is a function like this:

local function round(num)
    return math.floor(num+0.5)
end

and:

    num_x = mycustomlayout.nmaster or awful.tag.getnmaster(t)

I think 1-2 pixels less or more is a little splitting hairs over it (If one is able to catch them!), but if you solve this I'll be glad to merge.

I'll give it another try later, anyway.

[lcpz]

I tried a different approach, git pull and let me know.

[shmibs]

i made a screenshot and marked out the different widths along with the nominal width when using uselessfair:

[lcpz]

Are you sure this is the correct way to measure gaps?

Borders are part of a client. At least this is true for a layout arrange function.

This is what I measured:

So you're having the issue only with the last column.

This is very weird, I have the same resolution and no misplacements.

[lcpz]

Closed by c4c149d.