support binary attribute values about node-ldapjs

[mcavage]

Howdy,

Yeah, this was already on my list. Generally binary attributes are annotated by name as foo;binary. I was thinking of at least solving that and returning a buffer - would that work?

[nrogers]

I don't think the AD binary attributes follow a naming convention. For example, logonHours and objectGUID are both binary attributes.

So, I think the solution would have to work for all attributes.

[mcavage]

Ok, I'll think about it some and work something in; like I said, it was already on the list.

[mcavage]

Hi Nathan,

If you git pull the latest changes, anything touching an Attribute now has the following semantics:

• vals is actually an overload. Everything internally is kept as a Buffer
• If the attribute name ends in ;binary, then vals will return an array of base64 encoded strings, otherwise, it's the "old" behavior, of being handed as utf8
• If, like AD, you have things like objectGUID that are actually binary, but not tagged with a ';binary, you can now access .buffers as opposed to .vals and get an array of raw node Buffer objects. The length and order will be the same as .vals.

I think that should cover everything you need. Before I go publish - let me know if that covers (ideally, if you can test it that would rock :) ).

m

[nrogers]

Great, it looks like receiving binary attributes is working now in my tests.

It still seems to convert them to strings when I try to send them in a response, though.

-Nathan

-----Original Message-----
From: Mark Cavage [mailto:[email protected]]
Sent: Tuesday, October 11, 2011 4:02 PM
To: Rogers, Nathan
Subject: Re: [node-ldapjs] support binary attribute values (#21)

Hi Nathan,

If you git pull the latest changes, anything touching an Attribute now has the following semantics:

• vals is actually an overload. Everything internally is kept as a Buffer
• If the attribute name ends in ;binary, then vals will return an array of base64 encoded strings, otherwise, it's the "old" behavior, of being handed as utf8
• If, like AD, you have things like objectGUID that are actually binary, but not tagged with a ';binary, you can now access .buffers as opposed to .vals and get an array of raw node Buffer objects. The length and order will be the same as .vals.

I think that should cover everything you need. Before I go publish - let me know if that covers (ideally, if you can test it that would rock :) ).

m

Reply to this email directly or view it on GitHub:
#21 (comment)

[mcavage]

D'oh! I fixed everything except .toBer(), which was still writing them as a string. Try again :)

[nrogers]

Thanks, that looks good to me.

[mcavage]

Great. in npm as 0.2

[DenysVuika]

Has anyone managed to get it working with AD? like jpegPhoto attribute?

[mstllc]

Hey. I was struggling with this exact same thing and still can't quite figure it out. Specifically, I want to get objectGUID as a string, but it keeps coming all weird like. I'm not totally sure how to access the .buffer or .vals properties you mention above. I'm accessing everything in my search callback like entry.object.objectGUID and I see there is entry.attributes array which also contains all the attributes and their buffers, but is the only way to access them looping through that array and stopping at the item with the "type" key that matches the attribute I am looking for?

Thanks for any help.

[gdw2]

Something like entry.raw.objectGUID might work.

[pfmooney]

@gdw2 is correct, the entry.raw getter allows access to buffer objects which should fit your need.

[tstiemerling]

It seems AD needs objectGUID encoded in binary when using in a filter. We are currently explicitly converting the guid from string to binary for this, but would like to remove this if its not necessary. Any suggestions?