NotFilter throws exception during internal construction about node-ldapjs

[mcavage]

Thanks for the report Carsten. Last week there was a rewrite of the filter parsing code, so I'm pretty sure this is an aftershock :. I'll get it fixed up today.

[cwoelk]

Hi Mark,

I can confirm that your patch (SHA: 0e30dc5) does fix this issue in my setup. Thanks for fixing it that quickly!

Cheers,
Carsten

[mcavage]

Great, thanks for verifying - I just published 0.4.7 to npm, which has this fix. The NotFilters were the only ones that got missed in the rewrite logic, as they are subtly different than Or/And filters.

m

[cwoelk]

Great. Thanks. The npm module works fine too.
There is one more thing. I observed that the 'connect' callback for the Client is called twice now, once with the established connection and afterwards with 'undefined'. What is the second one for or is it an 'aftershock' too? ;)
I adjusted my code so it doesn't matter for me, but I am still curious and thought I might let you know. ;)
Cheers,
Carsten

[mcavage]

Hmm. No that's something else. Its probably been like that for a
while. I'll take a look at it tomorrow.

Sent from my iPhone

On Jan 25, 2012, at 1:41 AM, Carsten Woelk
[email protected]
wrote:

Great. Thanks. The npm module works fine too.
There is one more thing. I observed that the 'connect' callback for the Client is called twice now, once with the established connection and afterwards with 'undefined'. What is the second one for or is it an 'aftershock' too? ;)
I adjusted my code so it doesn't matter for me, but I am still curious and thought I might let you know. ;)
Cheers,
Carsten

---

Reply to this email directly or view it on GitHub:
#53 (comment)

[cwoelk]

I should mention that before the upgrade I was using the npm version 0.2.6. So unfortunately there are a few changes in between. :S

Test code is:

var ldap = require('ldapjs');
var client = ldap.createClient({
  url: 'ldap://127.0.0.1:1389'
});
client.on('connect', function(connection) {
  console.log(connection);
})

[mcavage]

K - I opened up #55 to track this new issue. I'll take a look at it.