req.dn is a string in Server.bind about node-ldapjs

[jsumners]

Are you suggesting a note be added to the v3 release notes? Or are you suggesting something else?

[gramakri]

@jsumners Oh, I thought this was a bug. Is this difference intentional? Per https://github.com/ldapjs/node-ldapjs/blob/master/docs/server.md#bind it still uses req.dn.toString() like in v2.

[jsumners]

Here's what I can tell you:

1. The direct change to the server.bind method for v3 was to utilize @ldapjs/protocol -- https://github.com/ldapjs/node-ldapjs/blame/bec2ff8e7399155ebdcbf86eec2077a792b8510b/lib/server.js#L577
2. The same link in 1 indicates that it has been expected to be a string for 12 years.
3. The _mount method (which builds the arguments for the handler) has a change that returns an @ldapjs/dn instance under the right conditions -- https://github.com/ldapjs/node-ldapjs/blame/bec2ff8e7399155ebdcbf86eec2077a792b8510b/lib/server.js#L908