GithubHelp home page GithubHelp logo

Comments (10)

le4ker avatar le4ker commented on June 20, 2024

Hmm I'm sorry but I don't get what you mean by "writeable area".

Can you please post screenshot/s to reproduce it?

I'm asking because we should understand the issue in order to fix it 😉

from personal-jekyll-theme.

altsheets avatar altsheets commented on June 20, 2024

what you mean by "writeable area".

The area that the text is rendered into.
It gets smaller when the whole window gets larger.

screenshot/s

Sure, no problem. Here:
http://i.imgur.com/YoVGbRR.png

Hope that helps :-)

P.S.: Using your theme as the basis for my new website (#46 (comment)). Thanks a lot :-)

from personal-jekyll-theme.

le4ker avatar le4ker commented on June 20, 2024

Oh I see what you mean..
I'm also new to CSS and I have no idea why this is happening.. But it's great that you have a fix! 😄

Our CSS champion is @joariasl by the way. @joariasl any ideas why this is happening? 😓

@altsheets Can you please open a pull request with your suggestion in order to test it and merge it with the repo? 😉

P.S.: Your website looks great! 😉

from personal-jekyll-theme.

joariasl avatar joariasl commented on June 20, 2024

This week I think that I have more free time. It is easy to fix. I will take a time to implement other improvements.

from personal-jekyll-theme.

le4ker avatar le4ker commented on June 20, 2024

@altsheets that's why we call him the CSS champion of the repo! 😜 👏

from personal-jekyll-theme.

altsheets avatar altsheets commented on June 20, 2024

It is easy to fix.

Nice. Happy to hear.

to implement other improvements

... and looking forward to those!

open a pull request with your suggestion

Not sure that is necessary.
All that needs to be added are the 7 lines up there in the OP.


Ah ... another good idea, to operationalize this, and to keep it clean.

  1. add two more css files, call them
  • personal.css, and
  • user.css
  1. load both by default from the html. (BELOW ... link href="grayscale.css and timeline.css )

put all your "personal-jekyll-theme" CSS changes into personal.css. And suggest to users / forkers ... to put their additional styles into user.css !

Then you can import the unchanged(!) grayscale.css and timeline.css from their original sources, and all your "personal-jekyll-theme" specific CSS will just override those. The advantage: If there are newer, updated commits of the original grayscale.css / timeline.css it will be really easy to merge them into PJT.
Plus, the end users (like me), will know where to put their style changes.

In my case, I had just added an "altsheets.css" into line 31, and put all my style changes into that file. This way I could keep your .CSS unchanged.

And CSS that is loaded later, will override CSS that is loaded earlier (I looked that up * g * ).


But it's great that you have a fix!

Happy to help. Cooperation ... that is best aspect of the internets.

P.S.: Your website looks great!

Thanks a lot. Yours, too * lol *

from personal-jekyll-theme.

le4ker avatar le4ker commented on June 20, 2024

Fixed here commit/004cf1f53e341b68ab9d80f11b290f2249ce34fe

from personal-jekyll-theme.

altsheets avatar altsheets commented on June 20, 2024

col-lg-8 col-lg-offset-2

col-lg-10 col-lg-offset-1

ah, that makes sense.

I had actually already suspected s.th. like that,
but I had not fully understood the underlying CSS.

Cool. Thanks a lot

from personal-jekyll-theme.

altsheets avatar altsheets commented on June 20, 2024

and what about the idea to leave the original

grayscale.scss
Grayscale Bootstrap Theme (http://startbootstrap.com)

untouched, and just override it with a (later-loaded)

personal-jekyll-theme.css

in which all the local changes are kept together?

See the 2nd part of #48 (comment)

For now, it might be a bit of a hassle, but a good compare-tool will make it easy. Long-term it is definitely of advantage.

Thanks for considering it.

from personal-jekyll-theme.

joariasl avatar joariasl commented on June 20, 2024

The original grayscale style contains any bugs not corrected.
I created a pull request for this project, but the project is apparently abandoned.
StartBootstrap/startbootstrap-grayscale#27
StartBootstrap/startbootstrap-grayscale#26

Another person saw the same errors:
StartBootstrap/startbootstrap-grayscale#18

At the end we should leave the modified copy, could not bear to leave these errors. 😜

from personal-jekyll-theme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.