GithubHelp home page GithubHelp logo

Comments (11)

ilvalle avatar ilvalle commented on May 27, 2024

+1

from leaflet.heat.

RobbieTheWagner avatar RobbieTheWagner commented on May 27, 2024

👍

from leaflet.heat.

mourner avatar mourner commented on May 27, 2024

I'll look into this, should be a matter of changing couple lines of code.

from leaflet.heat.

RobbieTheWagner avatar RobbieTheWagner commented on May 27, 2024

Thank you! :)

from leaflet.heat.

RobbieTheWagner avatar RobbieTheWagner commented on May 27, 2024

@mourner did you get a chance to look at this? If it is only a couple lines that need to be changed to support the new Layers extension, and you could tell me what those lines should look like, I could also start looking at some of the other layer plugins we are using and submit pull requests for the fix in other plugins to help this process along.

from leaflet.heat.

mourner avatar mourner commented on May 27, 2024

Done. As you can see, this was super-easy. Most plugins will only require one change — inheriting from L.Layer rather than L.Class.

from leaflet.heat.

RobbieTheWagner avatar RobbieTheWagner commented on May 27, 2024

Awesome, thanks! I appreciate your help.

from leaflet.heat.

RobbieTheWagner avatar RobbieTheWagner commented on May 27, 2024

I am in the process of updating all the plugins we use to support the new version of leaflet, and it appears that changing L.Class to L.Layer is not the only issue with Leaflet.heat. There is the following line in _animateZoom:

this._canvas.style[L.DomUtil.TRANSFORM] = L.DomUtil.getTranslateString(offset) + ' scale(' + scale + ')';

That method has been removed. What is the fix for this?

from leaflet.heat.

mourner avatar mourner commented on May 27, 2024

Did you actually look into the commit above?

from leaflet.heat.

RobbieTheWagner avatar RobbieTheWagner commented on May 27, 2024

Yeah, I looked at it. Is setTransform the new way of doing things? I just expected getTranslateString to no longer be used.

from leaflet.heat.

mourner avatar mourner commented on May 27, 2024

@rwwagner90 the commit above makes latest Leaflet.heat code work both with Leaflet 0.7.3 and Leaflet 0.8-dev.

from leaflet.heat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.