iOS & MacOS test failure due to port conflict, error message uninformative about patrol

[piotruela]

Hi. I can confirm that this issue exists. When PatrolServer or PatrolAppServiceClient fails because of the port conflict, we should exit the process and write an error message which will inform the user about what happened

[ewann]

In my head there is a Mac joke about "fail different", but when I went to look I didn't find much...

Today I realised when running tests on MacOS, neither --test-server-port 8096 --app-server-port 8095 nor:

export PATROL_TEST_PORT=8096
export PATROL_APP_PORT=8095

appear to work. Based on:

2024-04-14 21:51:40.476839+0100 RunnerUITests-Runner[8137:43450] PatrolServer: INFO: PATROL_TEST_PORT is null, falling back to default (8081)
2024-04-14 21:51:40.476889+0100 RunnerUITests-Runner[8137:43450] PatrolServer: INFO: PatrolServer constructor called
2024-04-14 21:51:40.476914+0100 RunnerUITests-Runner[8137:43450] PatrolServer: INFO: PATROL_ENABLED flag is defined
2024-04-14 21:51:40.477263+0100 RunnerUITests-Runner[8137:43450] PatrolServer: INFO: Starting server...
2024-04-14 21:51:40.478539+0100 RunnerUITests-Runner[8137:43450] PatrolServer: INFO: Server started on http://0.0.0.0:8081
2024-04-14 21:51:40.478552+0100 RunnerUITests-Runner[8137:43450] Create PatrolAppServiceClient
2024-04-14 21:51:40.478604+0100 RunnerUITests-Runner[8137:43450] PatrolServer: INFO: PATROL_APP_PORT is null, falling back to default (8082)
2024-04-14 21:51:40.478623+0100 RunnerUITests-Runner[8137:43450] PatrolAppServiceClient: created, port: 8082
2024-04-14 21:51:40.478634+0100 RunnerUITests-Runner[8137:43450] Run the app for the first time

I guess they are not getting passed Through. Since the remaining workaround (move services on conflicting ports somewhere else) is trial for my use case I didn't look into the code.

Until that can be addressed (alpha status in https://patrol.leancode.co/getting-started is noted) this hopefully saves someone else some time.

[ewann]

actually it's worse 🤣

This will hang indefinately

patrol test -d macos --verbose \
  --test-server-port 8096 --app-server-port 8095 \
  -t integration_test/enabled_tests

While this work work:

patrol test -d macos --verbose \
  -t integration_test/enabled_tests