GithubHelp home page GithubHelp logo

Comments (11)

avdv avatar avdv commented on May 27, 2024 1

@yanns I have opened ticket OSSRH-55040

from play-mockws.

yanns avatar yanns commented on May 27, 2024 1

@avdv congrats!
Maybe you can add the 2.8.0 to https://github.com/leanovate/play-mockws#adding-play-mockws-to-your-project ?

from play-mockws.

dgoetsch avatar dgoetsch commented on May 27, 2024 1

Thank you!

from play-mockws.

avdv avatar avdv commented on May 27, 2024

If you are only concerned about the Akka version, 2.6 is compatible to 2.5... So everything should just work if you ensure that you upgrade all of your Akka modules to the same version.

Still, a new release would be nice :-)

from play-mockws.

dgoetsch avatar dgoetsch commented on May 27, 2024

It is not compatible. There is a specific breaking integration with this library.

The MockWs class requires an ActorMaterializer in its constructor - but ActorMaterializer was deprecated. In our code, I can change all instances of ActorMaterializer to Materializer, except for those passed to MockWs. https://github.com/leanovate/play-mockws/blob/master/src/main/scala/mockws/MockWS.scala#L68

The code in this library has already been updated. I tested it by cloning and building locally; all that needs to happen is the release needs to be cut and put in the correct place.

from play-mockws.

yanns avatar yanns commented on May 27, 2024

@avdv do you want to take care of the release or should I?

from play-mockws.

avdv avatar avdv commented on May 27, 2024

It is not compatible. There is a specific breaking integration with this library.

@dgoetsch I was talking about binary compatibility. If you're programming against 2.6, you cannot expect that interface from libraries programmed against 2.5. So you would have to use deprecated APIs.

do you want to take care of the release or should I?

@yanns How? I could push the release button, but it seems I won't be able to push out the release to maven central... Or, can I?

from play-mockws.

yanns avatar yanns commented on May 27, 2024

@avdv please open a ticket on https://issues.sonatype.org to that they add your ssh key as allowed to publish those artifacts. And give me the ticket number so that I can confirm.

from play-mockws.

avdv avatar avdv commented on May 27, 2024

The 2.8.0 release is out!

from play-mockws.

yanns avatar yanns commented on May 27, 2024

thx @avdv 🏆

from play-mockws.

avdv avatar avdv commented on May 27, 2024

Maybe you can add the 2.8.0 to leanovate/play-mockws#adding-play-mockws-to-your-project ?

Right, forgot about that!

from play-mockws.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.