PDF Pages height are not rendering dynamically about kolibri

[ThEditor]

Alright, thanks! I've drafted a PR #11671 . Currently I've done some code changes to upgrade to vue-virtual-scroller v1.1.2 using RecycleScroller. I'll try to look into implementing DynamicScroller.

[marcellamaki]

I had forgotten too!! 😄 Great. No rush on this though :) if you'd like something to work on through the end of the year and this seems fun - it would be great for you to work on. But if you have other things to do that you'd rather focus on, that's okay too. We might be able to get this into one of our planned patches for 0.16.x though, which would be great. Thanks, @AlexVelezLl !

[AlexVelezLl]

Yes @ThEditor , you can import our QA channel as explained in this comment. Let me know if you have any issue!

[AlexVelezLl]

Oh, there's nothing to apologize for, take your time. We all have our things to do and you are taking a little of your time to help us! So thank you for that! 👐 No rush =)

That should be alright I suppose?

Yes! That's it.

[marcellamaki]

Completing the upgrade to Vue virtual scroller 1.1.2 and using the DynamicList and DynamicListItem components that support dynamic sizing would probably be the best approach for resolving this

[AlexVelezLl]

I had completely forgotten that I had a PR draft to update vue-virtual-scroller 😅, I'll take a look at that!

[ThEditor]

I've looked into this a bit and noticed that the migration from RecycleList (v0.12.0) to RecycleScroller (v1.1.2) has not been completed yet. I've got RecycleScroller to work locally and might be able to get DynamicScroller to work too.
I was wondering if I should look into it further and maybe draft a PR? @AlexVelezLl @marcellamaki

[AlexVelezLl]

Hi @ThEditor! Sure, you can! I remember that the migration to vue-scroller 1.1.2 had some minor issues that needed to be resolved. But if you already tried it and were able to run it locally, then cool! You're welcome to pen a PR 👐

[ThEditor]

I think I might've found a solution for DynamicScroller, however, I don't have a pdf to test these against. I tried visiting the ones mentioned in #11145 , however, I'm encountering "resource not found". Is there any other pdf content I can use for testing?

[ThEditor]

So, I imported the pdfs and the height issue seems to be fixed. Though there are two issues that still need to be addressed

• Fit to width: I'm not sure how we're planning to do this, a fit to width button might just be the solution? Is that what we will be going with?
• Loaded pages: From what I can understand, the latest commit in my PR isn't pre-loading pages before and after the current page. I think I might have to look at the buffer property provided by vue-virtual-scroller for this.

[AlexVelezLl]

Oh, no, that is out of scope. This issue was just to render dynamic sizing virtual list for PDF Renderer 😄

[ThEditor]

alright then, I've opened the PR #11671 for review, thanks!

[AlexVelezLl]

Perfect! Ill take a look in the afternoon. For now, can you please add some preview images?

[ThEditor]

I wasn't active when you mentioned me, apologies. I've added a preview video to PR. That should be alright I suppose?