GithubHelp home page GithubHelp logo

Permissive TX RLP deserialization causes early signing dialog when APDU packet boundary occurs immediately before chain ID about app-ethereum HOT 3 OPEN

prestwich avatar prestwich commented on August 16, 2024
Permissive TX RLP deserialization causes early signing dialog when APDU packet boundary occurs immediately before chain ID

from app-ethereum.

Comments (3)

adrienlacombe avatar adrienlacombe commented on August 16, 2024

thank you @prestwich could this help?
https://github.com/LedgerHQ/ledger-live/blob/11e4c3a0279612a8119e66bd4e3ebefcd689e417/libs/ledgerjs/packages/hw-app-eth/src/Eth.ts#L253

from app-ethereum.

prestwich avatar prestwich commented on August 16, 2024

We are applying a similar mitigation

Are you saying this is acknowledged and wontfix? Accepting invalid RLP seems like bad behavior in general

from app-ethereum.

prestwich avatar prestwich commented on August 16, 2024

ping on this, as people are still discovering this issue in the wild

from app-ethereum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.