Comments (7)
Actually, I would expect your example to work the same way as without the =
, so I do think that's a bug. It works for strings, for example:
opts = Slop.parse do |o|
o.string "-s", "--str"
o.array "-a", "--arr", default: ["default"]
end
p opts.to_h
ruby example.rb --arr "" --str="foo"
{:str=>"foo", :arr=>[]}
But with the =
it raises an error:
ruby example.rb --arr=""
Traceback (most recent call last):
7: from example.rb:6:in `<main>'
6: from /Users/lee/code/slop/lib/slop.rb:23:in `parse'
5: from /Users/lee/code/slop/lib/slop/options.rb:72:in `parse'
4: from /Users/lee/code/slop/lib/slop/parser.rb:49:in `parse'
3: from /Users/lee/code/slop/lib/slop/parser.rb:49:in `each_with_index'
2: from /Users/lee/code/slop/lib/slop/parser.rb:49:in `each'
1: from /Users/lee/code/slop/lib/slop/parser.rb:59:in `block in parse'
/Users/lee/code/slop/lib/slop/parser.rb:131:in `try_process': unknown option `--arr=' (Slop::UnknownOption)
This will need to be looked into.
from slop.
Actually, it doesn't work for blank strings either:
ruby example.rb --str=""
Traceback (most recent call last):
7: from example.rb:6:in `<main>'
6: from /Users/lee/code/slop/lib/slop.rb:23:in `parse'
5: from /Users/lee/code/slop/lib/slop/options.rb:72:in `parse'
4: from /Users/lee/code/slop/lib/slop/parser.rb:49:in `parse'
3: from /Users/lee/code/slop/lib/slop/parser.rb:49:in `each_with_index'
2: from /Users/lee/code/slop/lib/slop/parser.rb:49:in `each'
1: from /Users/lee/code/slop/lib/slop/parser.rb:60:in `block in parse'
/Users/lee/code/slop/lib/slop/parser.rb:132:in `try_process': unknown option `--str=' (Slop::UnknownOption)
So there's clearly a problem when parsing an array of options that includes an argument with an empty string when using the opt=arg
variant.
from slop.
Works like a charm. Thanks, @leejarvis !
from slop.
Using this code, I can pass in --foo ""
and the array will be empty. What is it you're expecting in this scenario? Or are you trying something else?
from slop.
I'm an idiot. I was trying to do --foo=""
and it was arguing with me. That works. Thanks!
from slop.
Yay! I'm not a total buffoon!
from slop.
@jrimmer-housecallpro Could you check your code against #268 and let me know how it goes?
from slop.
Related Issues (20)
- Thor comparison HOT 1
- ArgumentError not raised when Array arg is missing HOT 1
- Maybe support a choice option by default HOT 2
- Setting an option doesn't set it "everywhere" HOT 2
- Support for command in v4 HOT 1
- `help: false` throws off separator position HOT 4
- Attempt to modify frozen string litterals HOT 2
- Practical example HOT 5
- CI: Switch away from TravisCI HOT 6
- Conditional 'required' option HOT 2
- Custom message with Slop::MissingRequiredOption
- Ruby v3.0.0 problem with Slop v4.8.2 HOT 2
- Some bugs. HOT 1
- Enable frozen strings in Slop using the `# frozen_string_literal: true` pragma HOT 1
- [question] is there a way to check that one or more of some set of args exist? HOT 2
- Default value for boolean flags not working when invoking method HOT 1
- Issue / breaking change with boolean flags with 4.10.0 HOT 2
- Confusing that there's a 4.0 branch... HOT 1
- Bool options bug! HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from slop.