XMLDocument::PrintError crashes with errorStr size > 20 about tinyxml2

[leethomason]

Any chance you have a small test case?

[TheClassic]

XMLDocument doc;
if(XML_NO_ERROR != doc.LoadFile( "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" ))
{
doc.PrintError();
return doc.ErrorID();
}

[TheClassic]

The following code for PrintError seems to work for me, even if errorStr2 is null. Not sure if you're trying to limit the size of the error msg, or avoid passing a null pointer to printf

if ( errorID ) {
    printf( "XMLDocument error id=%d str1=%s str2=%s\n",
            errorID, errorStr1, errorStr2 );
}

[leethomason]

Wow, huge screaming bug in the "safe" printf handling. I'm not even sure why it's compiling, or ever creating correct output. In any case, hopefully fixed much more correctly now.

The limit of 20 is because either of those strings can contain the entire XML file in some cases.