Comments (3)
A fair point, but styles are subjective - I mention in https://github.com/leibnitz27/cfr/blob/master/contributing.md - I'm not massively bothered about coding styles where there's any disagreement in the wild, given that (if you're particular about that sort of thing) it's trivial to run eg google-format-java over output (with your own personal preferences set).
Re labels - due to the nature of the beast, CFR is occasionally going to generate a lot more labels than you'd find in production code - I find condensing like that a readability bonus.
from cfr.
I've had a wander trying to actually find a single style guide that explicitly mention varargs ellipsis. Google java doesn't actually seem to care.
https://rules.sonarsource.com/java/RSPEC-3878 is the only one I found, and this has the extra explicit space!
I have to confess, I prefer it, for no particular reason, (though perhaps that's my c++ talking).
from cfr.
I'm going to close this - it's a minor subjective stylistic issue which can easily be patched up with a formatting tool. While this may seem a little aribtrary given #167 , that is more of an intrustive change, which is harder for a trivial style checker to apply.
from cfr.
Related Issues (20)
- CFR incorrectly decompiles stack values being reordered
- aload_0 - astore_2 for different types produces wrong code
- How to get cfr .jar building from source? HOT 1
- module-info cannot be decompiled after packing into jar
- Decompiling specific package(s) HOT 3
- CFR generates incorrect code for type arguments
- CFR may perform incorrect modifications to the type of generic class variables
- CFR generates duplicate variable names inside and outside lambda expressions
- Type argument of null reference generic class variables is converted to Object
- Casting of primitive types may be decompiled as casting of corresponding wrapper classes under certain circumstances
- Type Conversion Expression Lost in Constructor
- Question: Is there any switch to specify a single class to be decompiled? HOT 1
- How can I show the class packages?
- Option to remove the file headers HOT 1
- Question: decompiling multiple files from terminal HOT 1
- How do I decompile using CFR's CFRDriver?
- Decompiling class files from Java bytecode source HOT 2
- Ternary Expression Causing Decompilation Type Error
- Incorrect Comparable Expression Produced by Ternary Expression
- CFR can't handle recent Oracle JDBC jars HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cfr.