GithubHelp home page GithubHelp logo

Code formatting standards about cfr HOT 3 CLOSED

leibnitz27 avatar leibnitz27 commented on July 17, 2024
Code formatting standards

from cfr.

Comments (3)

leibnitz27 avatar leibnitz27 commented on July 17, 2024

A fair point, but styles are subjective - I mention in https://github.com/leibnitz27/cfr/blob/master/contributing.md - I'm not massively bothered about coding styles where there's any disagreement in the wild, given that (if you're particular about that sort of thing) it's trivial to run eg google-format-java over output (with your own personal preferences set).

Re labels - due to the nature of the beast, CFR is occasionally going to generate a lot more labels than you'd find in production code - I find condensing like that a readability bonus.

from cfr.

leibnitz27 avatar leibnitz27 commented on July 17, 2024

I've had a wander trying to actually find a single style guide that explicitly mention varargs ellipsis. Google java doesn't actually seem to care.

https://rules.sonarsource.com/java/RSPEC-3878 is the only one I found, and this has the extra explicit space!

I have to confess, I prefer it, for no particular reason, (though perhaps that's my c++ talking).

from cfr.

leibnitz27 avatar leibnitz27 commented on July 17, 2024

I'm going to close this - it's a minor subjective stylistic issue which can easily be patched up with a formatting tool. While this may seem a little aribtrary given #167 , that is more of an intrustive change, which is harder for a trivial style checker to apply.

from cfr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.