GithubHelp home page GithubHelp logo

Comments (10)

cosmin-novac avatar cosmin-novac commented on May 31, 2024 2

Thanks.

In case someone else is struggling with this: I identified the cause of the issue, I'm using meteor's standard minifier in production. It seems minifying js files messes with ejs templates. I'm now working to either skip minification for this package completely, or to identify what part can't be properly minified.

from jepub.

lelinhtinh avatar lelinhtinh commented on May 31, 2024 1

If you're building from source code, it's actually crashing. I'm developing on branch... master (つ﹏<。)

from jepub.

cosmin-novac avatar cosmin-novac commented on May 31, 2024 1

Ok, so after some struggle, the solution was quite simple. I loaded both ejs and jepub directly from a CDN instead of adding them via the dependency tree. This way they simply skip any build/minimization process.

I think both the webpack minification and the jake postinstall had caused conflicts with my own minifier, so the pre-built versions solved it.

Thanks for the support!

from jepub.

cosmin-novac avatar cosmin-novac commented on May 31, 2024

Quick note: I've installed ejs v3.1.6 via npm, but I just noticed that jepub comes with its own [email protected] postinstall...

from jepub.

cosmin-novac avatar cosmin-novac commented on May 31, 2024

No, I just installed jEpub via npm, that is definitely the tagged v.2.1.4

And regarding ejs, I went down to v2.7.4 on my npm dependency, and then I removed it completely and just used the module in jEpub, but the error still persists... Any ideas?

from jepub.

lelinhtinh avatar lelinhtinh commented on May 31, 2024

Check it out https://codesandbox.io/s/7thjk

from jepub.

cosmin-novac avatar cosmin-novac commented on May 31, 2024

Hm, I'm not sure what I'm supposed to be looking at? Setting the global.ejs? Or adding metadata console logs to debug?
Locally it's working fine, there is no issue.

from jepub.

cosmin-novac avatar cosmin-novac commented on May 31, 2024

I forked the repo and tried bumping ejs to the latest version as well as hardcoding the i18n labels, but the error persists...

from jepub.

cosmin-novac avatar cosmin-novac commented on May 31, 2024

I just ran the project with the production flag activated, and now I can reproduce the issue locally. So I guess it must have something to do with dev dependencies...

from jepub.

lelinhtinh avatar lelinhtinh commented on May 31, 2024

I created a branch on the last commit that it was working on.

git checkout develop
npm install
npm start

from jepub.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.