Unnamed namespace causes ODR violations in C++ about fastmod

[lemire]

Given that we want this code to work in C, and want to be as portable as possible, what do you propose as a better design?

[jwakely]

Just don't use an anonymous namespace.

[lemire]

@jwakely If you include the header in more than one location in your project, then you are going to get several definitions for the same functions.

My own code called the function 'static' (C). This works, obviously.

However, since C++11, C++ purists want to drop 'static' in favor of unnamed namespace, which is what we have here.

So... I don't think we can drop the unnamed namespace and leave it at that. If you think I am wrong, please elaborate.

[jwakely]

Oh, I assumed the functions were already inline. That's the solution for C++. No unnamed namespace, but inline. Now they can be included in multiple files and defined multiple times, but you get identical definitions in each.

[lemire]

It appears to fail with errors like...

include/fastmod.h: In function ‘uint32_t fastmod::fastmod(uint32_t)’:
include/fastmod.h:174:26: error: ‘v’ declared as an ‘inline’ variable
     FASTMOD_API uint64_t v = computeM_u32(d);

[lemire]

Closed with a PR from @jwakely