Comments (7)
Hi @jingledongding thank you for reporting this.
Can I please ask you some clarifications?
When there is a risk of snapshotting potentially volatile voting details, accessing the voting information becomes unreliable, and it may lead to a potential crash of the shared kernel.
Can you please expand on what you mean by "there is a risk of snapshotting potentially volatile voting details"?
What makes it volatile? Was the proposal definition amended while you where testing the hook?
from lens-sdk.
When I access https://snapshot.org/#/lido-snapshot.eth/proposal/0xbf00c00a2e9c009e9d014e1ed4885d2b77d525ffb1c7495479f750a915f30f2e, the snapshot doesn't redirect to the correct page, which results in the hook not receiving the correct response.
from lens-sdk.
I've noticed the same warning on the Snapshot UI... never seen it before.
Seems a spam prevention feature of Snapshot UI itself.
Is the Snapshot URL correct? Is this a legitimate Proposal?
In order to integrate with Snapshot the Lens SDK hook does not access the same HTML page you open with the browser but instead extracts the Proposal Id and Space Id and uses Snapshot GQL APIs to retrieve the relevant details.
from lens-sdk.
Is the Snapshot URL correct?
this url is from @lensprotocol/react, so I think it's correct
Is this a legitimate Proposal?
It's possible that only someone with access to the snapshot would know this, but based on the information available, the proposal appears to be sensitive."
from lens-sdk.
Ah I see. I thought it was a Snapshot Proposal you tried to use in a publication content. Instead if I understood correctly it kinda landed on you because it made your code crash.
The Lens SDK itself does not have any specific Snapshot Proposal URLs in it. Ultimately this comes from the content of a publication that you happened to have fetched with the Lens SDK.
Unfortunately it's content we don't have control over, so the only thing we can do is being robust to "odd things".
The reason I am asking about the legitimacy of this specific Snapshot Proposal is that the Snapshot UI that warns about it is a first red flag.
A second red flag is the fact the proposal is a Single Voting choice but only provides a Yes
choice.
So from a Snapshot vote perspective it's either one votes yes or they abstain. This is ultimately the cause of the error you see, in the SDK we assumed only legitimately configured Snapshot Proposal.
The link in the description and the Space ID is also suspicious.
I am going to plan a fix that if possible silently ignores these misconfigurations.
Thank you for taking the time to explain the background of this issue to me. Will ping you when a fix is available.
from lens-sdk.
Fix coming soon: #456
from lens-sdk.
This is now available in:
@lens-protocol/react@next
@lens-protocol/react-web@next
@lens-protocol/client@next
It will be released 1.3
stable next week.
from lens-sdk.
Related Issues (20)
- Unable to retrieve the latest publication. @lens-protocol/react":1.3.1 HOT 3
- My React Native project encountered significant issues when upgrading to V2 HOT 4
- Add WalletAuthetificationToProfileAuthetification to sdk HOT 3
- Here is the diff that solved my problem: HOT 2
- The 'useOwnedHandles' hook failed to execute correctly in the production environment
- It seems that the data provided by useOwnedHandles is not sufficiently real-time. I am unable to retrieve the profile I purchased through this hook. HOT 2
- Support Node Engine 20 HOT 3
- When I switch to a new wallet, LensProvider doesn't replace with the new signer. Can anyone help me look at this issue HOT 3
- useSetProfileMetadata should update the profile cache returned by useSession HOT 2
- Support wagmi v2 HOT 5
- In the useOpenAction react hook, when the user doesn't have enough funds to collect, an unhandled promise is being thrown instead of being handled by the SDK HOT 7
- Add support for React suspense HOT 9
- Regression in latest version of the SDK 2.0.0-alpha.29 when creating a publication HOT 9
- Get a refreshed access token if expired HOT 29
- SSR support with the React SDK HOT 2
- export 'isObject' (imported as 'isObject') was not found in '@lens-protocol/shared-kernel' HOT 3
- Apollo cache issue when liking or bookmarking your own posts HOT 5
- @lens-protocol/react-web HOT 4
- usePublications failed to execute if one of publication on scope have an invalid encryption condition HOT 1
- verifyFrameSignature: SIGNER_ADDRESS_CANNOT_USE_PROFILE(Lens Frame) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lens-sdk.