In the useLogin react hook, when the user cancel the signing message modal, an unhandled promise is being thrown instead of being handled by the SDK about lens-sdk

[reecejohnson]

thanks for raising this @pradel

i was able to reproduce this, thanks for the detailed reproduction steps.

we are taking a look into the cause now.

i will keep update this issue once resolved 👍

[cesarenaldi]

#806

[cesarenaldi]

Fix for this available in: @lens-protocol/[email protected] and @lens-protocol/[email protected]

[reecejohnson]

@pradel see mentioned PR for small fix that better handles this error

this is not related directly to our React SDK but more so an issue with our example app using wagmi and viem

we do already handle the case where a user rejects the request in the login flow

this error was coming from before the login flow was executed, in the connection of the wallet to example app

i've added an onError callback to this example to better handle this case

[pradel]

@reecejohnson from my tests the error is coming from the login flow (when you sign a message), not the connect flow. It was working properly with the V1 of the SDK but not with the V2 so maybe a regression?

[reecejohnson]

@pradel i see, can you provide some information around which wallet you're using? and a screen recording if possible

[cesarenaldi]

@pradel any update on this?

[pradel]

The issue is still happening with the latest version, I am using Taho Wallet and it can be reproduced in the lens example consistently https://lens-sdk-example-web-wagmi.vercel.app/login

[pradel]

@cesarenaldi @reecejohnson this is the video showing the issue I am facing.

Screen.Recording.2024-01-03.at.19.08.02.mov

[cesarenaldi]

@pradel thank you for the video, this is now more clear. Internally the SDK uses ethers.js, it seems something is not working with the RPC wallet error codes and ethers.js error codes mapping.

We will need to investigate this further to assess if this can be patched or requires to upgrade ethers.

We will get back to you when we know more. Thank u for now.

[cesarenaldi]

@pradel we will be able to allocate proper time to look into this next week.

I understand this is happening only in the very particular circumstance that a user refuse (from their Taho Wallet) to sign the login challenge text. So seems to not affect the rest of the app experience when the user wants instead to continue w/ login. Is this correct?

[pradel]

Correct, it's not critical as the user can continue the flow as usual.

[pradel]

@cesarenaldi just tested with Rabby wallet and the same issue is happening. I think this used to work fine with the v1 of the SDK but not 100% sure.

[cesarenaldi]

Hey @pradel thank you, I managed to spot the issue using Rabby. Will include a fix in the next SDK release.