Comments (14)
thanks for raising this @pradel
i was able to reproduce this, thanks for the detailed reproduction steps.
we are taking a look into the cause now.
i will keep update this issue once resolved 👍
from lens-sdk.
from lens-sdk.
Fix for this available in: @lens-protocol/[email protected]
and @lens-protocol/[email protected]
from lens-sdk.
@pradel see mentioned PR for small fix that better handles this error
this is not related directly to our React SDK but more so an issue with our example app using wagmi
and viem
we do already handle the case where a user rejects the request in the login flow
this error was coming from before the login flow was executed, in the connection of the wallet to example app
i've added an onError
callback to this example to better handle this case
from lens-sdk.
@reecejohnson from my tests the error is coming from the login flow (when you sign a message), not the connect flow. It was working properly with the V1 of the SDK but not with the V2 so maybe a regression?
from lens-sdk.
@pradel i see, can you provide some information around which wallet you're using? and a screen recording if possible
from lens-sdk.
@pradel any update on this?
from lens-sdk.
The issue is still happening with the latest version, I am using Taho Wallet and it can be reproduced in the lens example consistently https://lens-sdk-example-web-wagmi.vercel.app/login
from lens-sdk.
@cesarenaldi @reecejohnson this is the video showing the issue I am facing.
Screen.Recording.2024-01-03.at.19.08.02.mov
from lens-sdk.
@pradel thank you for the video, this is now more clear. Internally the SDK uses ethers.js, it seems something is not working with the RPC wallet error codes and ethers.js error codes mapping.
We will need to investigate this further to assess if this can be patched or requires to upgrade ethers.
We will get back to you when we know more. Thank u for now.
from lens-sdk.
@pradel we will be able to allocate proper time to look into this next week.
I understand this is happening only in the very particular circumstance that a user refuse (from their Taho Wallet) to sign the login challenge text. So seems to not affect the rest of the app experience when the user wants instead to continue w/ login. Is this correct?
from lens-sdk.
Correct, it's not critical as the user can continue the flow as usual.
from lens-sdk.
@cesarenaldi just tested with Rabby wallet and the same issue is happening. I think this used to work fine with the v1 of the SDK but not 100% sure.
from lens-sdk.
Hey @pradel thank you, I managed to spot the issue using Rabby. Will include a fix in the next SDK release.
from lens-sdk.
Related Issues (20)
- Unable to retrieve the latest publication. @lens-protocol/react":1.3.1 HOT 3
- My React Native project encountered significant issues when upgrading to V2 HOT 4
- Add WalletAuthetificationToProfileAuthetification to sdk HOT 3
- Here is the diff that solved my problem: HOT 2
- The 'useOwnedHandles' hook failed to execute correctly in the production environment
- It seems that the data provided by useOwnedHandles is not sufficiently real-time. I am unable to retrieve the profile I purchased through this hook. HOT 2
- Support Node Engine 20 HOT 3
- When I switch to a new wallet, LensProvider doesn't replace with the new signer. Can anyone help me look at this issue HOT 3
- useSetProfileMetadata should update the profile cache returned by useSession HOT 2
- Support wagmi v2 HOT 5
- In the useOpenAction react hook, when the user doesn't have enough funds to collect, an unhandled promise is being thrown instead of being handled by the SDK HOT 7
- Add support for React suspense HOT 9
- Regression in latest version of the SDK 2.0.0-alpha.29 when creating a publication HOT 9
- Get a refreshed access token if expired HOT 29
- SSR support with the React SDK HOT 2
- export 'isObject' (imported as 'isObject') was not found in '@lens-protocol/shared-kernel' HOT 3
- Apollo cache issue when liking or bookmarking your own posts HOT 5
- @lens-protocol/react-web HOT 4
- usePublications failed to execute if one of publication on scope have an invalid encryption condition HOT 1
- verifyFrameSignature: SIGNER_ADDRESS_CANNOT_USE_PROFILE(Lens Frame) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lens-sdk.