GithubHelp home page GithubHelp logo

Comments (10)

LenweSaralonde avatar LenweSaralonde commented on July 26, 2024

TRP3 and Musician use the exact same logic to keep their communication channels at the end so it doesnโ€™t mess up with your own custom channels.
However, the logic for the coloring might be handled separately which might cause this issue. In addition, I personally encounter some issues with the NewcomerChat that keeps moving to position 1, regardless if I use add-ons or not.
Iโ€™ll do more tests on my side and see if I can fix it.

from musician.

CrazyMaze10101 avatar CrazyMaze10101 commented on July 26, 2024

Sorry I'm just now replying, I had kind of forgotten about this. My colors, even after not touching my channel colors, and having all my addons on, are still being randomized. My trade earlier was purple, but now it's red, so I guess it doesn't just change once, perhaps I just wasn't waiting for my character to de-load

from musician.

LenweSaralonde avatar LenweSaralonde commented on July 26, 2024

The custom colors are not linked to channel names but channel indexes. Musician joins its communication channel very early in the player login process, sometimes before joining any other channel (General, Trade etc) which may result in the colors being shifted, even after logging out my character "properly" (no alt+F4 etc).

I tried delaying the channel joining process and it seems to fix the problem but I won't guarantee that it will work 100% of the times because the way Blizzard handles chat channels always have been a bit messy. In addition, some other add-ons also have their own way of joining and reordering their own channel which can also cause side effects.

from musician.

LenweSaralonde avatar LenweSaralonde commented on July 26, 2024

@CrazyMaze10101 Could you please test using the latest patchset ?
Be sure to rename the folder from the zip file into Musician to overwrite your existing Musician installation and to disable all your other add-ons (Total RP has a similar problem and may interfere).

from musician.

CrazyMaze10101 avatar CrazyMaze10101 commented on July 26, 2024

Ok, I'll test it now, ty. I'll see how it works here soon

from musician.

CrazyMaze10101 avatar CrazyMaze10101 commented on July 26, 2024

I had my channels all in pastel rainbow order for the test. So, for my first reset, my orange went all the way down to the bottom, which is Musician chat, but everything else is all good and in the same order it was originally in. 2nd login, same thing.
And then, when I changed ONLY the musician chat after everything else was scrambled, it did it again? Everything but my 1 channel moved up, so now I had my yellow in musician spot, and the white that I had changed it to is now in my 10 spot. So far, only Newcomer hasn't changed (and it's my 1 spot).
My last test is going to be, changing my colors to the desired colors, except back 1 spot. It worked, but I am unsure if this will be a permanent stick, not to mention I do not have TRP3 on as well, so hopefully it doesn't break if/when I turn it on.

from musician.

LenweSaralonde avatar LenweSaralonde commented on July 26, 2024

my orange went all the way down to the bottom, which is Musician chat, but everything else is all good and in the same order it was originally in.

This is expected behavior.

The MusicianComm channel is temporary channel, which means its channel number is not persistent and may change at the next login. In addition, channel colors are bound to channel numbers. Let's say you have MusicianComm at position 7 with color red and have green for position 8. In your next session, you might end up with MusicianComm set to position 8 with color green. This is a bit counter-intuitive but this is the way Blizzard implemented chat colors and unfortunately, we can't do anything about it. ๐Ÿ˜•

Please keep in mind that most add-ons, including Musician, automatically move their chat channels to the end so it doesn't clutter up your regular channels. If you move MusicianComm among your regular chat channels you use for actually chatting, you may end up with some channel numbers and colors being messed up the next time you login.

Also, please avoid gaps between channels because add-ons channels have their position automatically set and they may end up in gaps, then bubble up to the end which may shuffle colors as well.

So far, only Newcomer hasn't changed (and it's my 1 spot).

The NewcomerChat bug occurs when it's the first channel to be actually joined at login and it's not at position 1. Yours is at position 1 so you're not affected but I usually put mine at position 5 and it used to change all the time because of this bug which is very annoying.

I do not have TRP3 on as well, so hopefully it doesn't break if/when I turn it on.

Unfortunately, the channel joining logic was copy-pasted from TRP3 so this TRP3 is affected too. The good news is I managed to fix it as well, the same way I fixed Musician and it seems to work fine now. I'll raise a ticket and open a PR on their project to have it fixed for everyone.

from musician.

CrazyMaze10101 avatar CrazyMaze10101 commented on July 26, 2024

Ok, so since it seems impossible to have my musician chat at 2 instead, and no way to leave it, my only choice is to deal with the color changes, have all my channel colors the same, or delete musician (And possibly TRP3 as well)? If so, then I'll just consider this closed if there doesn't seem to be a fix, I don't want you to have to work a ton just for a quality-of-life thing most others don't care about and most likely wouldn't encounter.

from musician.

LenweSaralonde avatar LenweSaralonde commented on July 26, 2024

The addon channels for Musician, TRP and other addons are not intended to be used for chatting so you don"t have to bother setting a color for them and they should remain at the end of the list.

What you can do (when the fixed version of Musician and TRP are available) is to set rainbow colors to your permanent channels and leave the default color for the addon channels that remain at the end of the list.

from musician.

LenweSaralonde avatar LenweSaralonde commented on July 26, 2024

The fix has been implemented into TRP3 as well.

from musician.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.