Comments (12)
@worldwidemv thanks for reporting this, I never saw this issue happening before. Is it possible to share the repo with me, so I can give it a try by myself?
As a workaround, instead of changing your sources, you can use the flag -t N
to show only the latest N commits. Can you check it this work for you?
Now, talking about the hash size, I found this right now.
It looks like there is no standard short version of hash as I thought before.
I am going to experiment with your solution that uses longer or the full shash and if it is good, then I think I am going to adopt it.
from kiri.
Ah, since git was using short hash, the reason to keep that was to be able to pass a simple hash to kidiff from the command line, if the user wanted to skip the use of the GUI, but it is fine to use the long hash since it is easy to copy and paste it, and I believe no one will write the hash character after character by hand.
from kiri.
Unfortunately I can not share the repository. Personally, I don`t believe the repo is so large, that it normally would need 8 digits statistically. But if the first 7 match somehow, they match...
Apparently the short hash size is configurable via core.abbrev
but the default is auto
with 7 as the minimum.
I already called kiri -r -t 3 -D X.kicad_pro
.
Using the full 40 digits hash also might be to much, because the short hash is way easier to compare and it is also used in the web interface as kind of a version number and all that makes sense, as long the short hash is unambiguous.
I think GIT makes sure that is the case if the length is not overridden. So in my opinion, using the current GIT output is better than using the full hash.
And if there is no reason to force kidiff
to use only 7 digits then this would be fix.
from kiri.
Yeah, the current Kicad-Diff
submodule kiri
is using is my fork of it so I can have more control over it.
The code to fix that is already been pushed, you can go ahead and update the Kicad-Diff submodule inside the kiri repo.
Kiri is still using a short version of the hash, please, check again if it works or if it already needs to be fixed, since running it here on my repo does not show any issue. However, I am thinking it is better to have this hash changed as well.
from kiri.
fixing Kiri is not straightforward, since it messes up the design page layout a bit, and this may take a bit of thinking. but let me know if it needs to be fixed, or not, cool?
Example of what I am talking about. Not hard to improve but some details need some focus.
from kiri.
Well, I started by increasing the hash size of kiri to 8, it this is not enough, we can try 10. This may not interfere with the layout too much that I have to do too many changes. =)
from kiri.
I don't think is necessary to force that. GIT does it automatically if necessary. The different parts of kiri
just have to support it.
So the changes to kidiff
are sufficient in my opinion. I would even revert the changes to line 106 in git.py
. But it does not seam to hurt....
Forcing 8 digits might might not work for repos, that need 9 digits to be unambiguous.
I tested 1455d96, and that works fine.
from kiri.
from kiri.
true, but in kidiff, I saw it was not a big deal.
@worldwidemv it is good to keep the line 106 as it is now, since it will match the other places to keep the coherency.
@Gasman2014 I am about to make a pr with this new code to the main
about kiri, yeah, it looks like it is ok to keep using the default short hash as you said, I am going to revert this.
from kiri.
ah @worldwidemv now I got it, the way kidiff was getting the hash was a bit hardcoded. I am going to use the short version there too since it is automatic. the issue was the array-slicing method we were using. But now, it is slicing by the whitespace. Then we can use the short version nicely.
from kiri.
Hm. When I looked at the commit1
variable there was only the hash inside.
But, I don't know much Python.
Next time I will add a "how to recreate" section.
Thanks for the fix.
Have a nice Christmas.
from kiri.
You too @worldwidemv , have a nice Christmas.
from kiri.
Related Issues (20)
- Fix dependency installation for first time installation HOT 1
- Installing kiri on Ubuntu (Command 'kiri' not found, did you mean:) HOT 2
- feature request: highlight pages and layers that have changes HOT 9
- Issues reported on KiBot integration HOT 3
- Specifing *.kicad_pro file as parameter seems not to work HOT 18
- WLS2 Error on missing submodules.kicad_parser HOT 1
- Hierarchical Schematic Sheets HOT 12
- KiCAD 8.0 Support HOT 4
- Cannot view board layout HOT 17
- Unable to view schematic or layout diff HOT 6
- KiCad 8 support HOT 2
- Layout View is not showing my board HOT 3
- Not showing all pages and no layout HOT 18
- Unable to view schematic or layout diff (kiri: line 311: printf) HOT 18
- root index.html redirects to absolute path HOT 3
- Python port RFC HOT 1
- PCB cutoff when past A4 page borders HOT 4
- Update install_plugin.sh for KiCad 7.0 HOT 4
- Toggle between new and old view HOT 15
- svg from plotgitsch in wrong directory HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kiri.