Github Repo TypeError: Cannot read property 'repository' of undefined about vscord

[nick22985]

It not doing it now.
Closing as it seems it is not doing it now

[nick22985]

Reopening this I have re created it with the deployed version.
https://youtu.be/8K8ehSd_ig0

So it appears that non git repo projects just says idle

[nick22985]

lmao always the way xD

[leonardssh]

@danivideda discord related stuff. See #20 (comment)

[leonardssh]

A reproduction code? 'Cause I can't reproduce it.

[leonardssh]

The only thing I haven't tested, in non-git environment. 😄

[nick22985]

Another thing to note. Now if you open vscode inside with a file already open. The rpc will not display. Until changing the file. This issue might be related to something about when a git repo isnt detected it does show anything maybe?

[leonardssh]

I've found the problem, yep, it's related to the Git API. I've almost got it.

[nick22985]

Updates now but does not clear out the repo url button. So when switching from a git repo to the non git repo it will display the button to link back to your previous repo. If you have Rpc: Button Incative label / Button inactive url set. It also does not update the values to those correct values as well / git repo never updates

https://youtu.be/JXS4H6kEhq8

@leonardssh Can not re open issues. Unless u want me to create new ones?

[leonardssh]

I'm investigating...

[leonardssh]

@nick22985 can you test it now?

[nick22985]

@leonardssh When folder is not in a repo. Does not display Inactive button. Switching now is working.

[nick22985]

Think i found the probelem

[nick22985]

So this is the fix
Line 130 in activity.ts. The problem is that dataClass.gitRemoteUrl} needs to be changed to a asynchronous function so that it waits to see the results from the api call before returning. This way we dont run into issues with if the API has not returned the a value it going to the inactive git repo button and u having to wait until u switch files again for it to update

if (config[CONFIG_KEYS.ButtonEnabled]) {
	console.log(`${dataClass.gitRemoteUrl}`);
	if (dataClass.gitRemoteUrl) {
		const gitRepo = dataClass.gitRemoteUrl.toString('https').replace(/\.git$/, '');
		const gitOrg = dataClass.gitRemoteUrl.organization ?? dataClass.gitRemoteUrl.owner;

		const isRepositoryExcluded = isExcluded(config[CONFIG_KEYS.IgnoreRepositories], gitRepo);
		const isOrganizationExcluded = isExcluded(config[CONFIG_KEYS.IgnoreOrganizations], gitOrg);

	 	const isNotExcluded = !isRepositoryExcluded && !isWorkspaceExcluded && !isOrganizationExcluded;

		if (gitRepo && config[CONFIG_KEYS.ButtonActiveLabel] && isNotExcluded) {
			presence = {
				...presence,
				buttons: [
					{
						label: config[CONFIG_KEYS.ButtonActiveLabel],
						url: gitRepo
					}
				]
			};
		}
	} else if (!dataClass.gitRemoteUrl && config[CONFIG_KEYS.ButtonInactiveLabel] && config[CONFIG_KEYS.ButtonInactiveUrl]) {

[leonardssh]

Yeah, I think I need to take a look at the Data class code, get it purified.

[nick22985]

The other thing when i was looking around trying to fix it. It also looks like it resets the presence every time so for a second u see the idle state then it switches to the config.

[leonardssh]

Yeah, that's what I noticed, something is wrong.

[danivideda]

I was about to raise an issue where the 'View Repository' button didn't do anything.
Is this what caused it?

[leonardssh]

@nick22985 the problem still persist? After the last couple updates?
@danivideda the problem seems to be solved, I think the people at discord have finally made it so you can click your own button (at least it works for me)

[nick22985]

Sorry for the late response @leonardssh.
Yea the issue seems to have been Fixed.