Comments (16)
i will figure it out soon
from vscord.
Doing more testing this is related to ignored workspaces when user is remote ssh into a vscode instance
#36 This prob be fixed apart of this issue
from vscord.
cd4fabb might hopefully fix this, i will push the update out soon
from vscord.
nevermind, can you please give me your settings so i can test it
from vscord.
Hey @xhayper,
Here are my settings. There also looks to be a regression. Now it only shows idle and not the ignoreWorkspacesText. When going to a new file it then shows the repo. This only happens when you are ssh'ed inot a separate machine coding also
{
"rpc.buttonInactiveLabel": "Check Out My Github",
"rpc.buttonInactiveUrl": "https://github.com/nick22985",
"rpc.appName": "Visual Studio Code",
"rpc.ignoreOrganizations": ["IgnoredOrg"],
"rpc.ignoreWorkspaces": ["Repo1", "Repo2", "Repo3", "Repo4", "Repo5", "Repo6"],
"rpc.ignoreWorkspacesText": "[Redacted]",
"rpc.buttonEnabled": true,
"rpc.enabled": true,
"rpc.checkIdle": true,
"rpc.resetElapsedTimeAfterIdle": true
}
from vscord.
ah shoot, i dont know how ssh coding work, this might be s trouble for me to debug
from vscord.
@xhayper I did some digging into this. What it appears to be is that dataClass.workspaceFolder
returns undefined
Line 105 in b3c4ae0
which checks the const uri = window?.activeTextEditor?.document.uri;
which is undefined
Line 91 in b3c4ae0
Causing the check for the isExcluded to fall over and not run
Line 112 in b3c4ae0
from vscord.
this is really REALLY a problem, because that's the only way we know how to find what folder we are on
from vscord.
currently trying to think of a way we can work around this
from vscord.
@xhayper
Maybe this is actually an issue with the vscode npm plugin
My one thought which would be kinda quick and dirty would be to regex whatever value is the string for the workspace folder. But I assume this will cause more issues for other things so prob better finding a better soloution to this.
My next idea would be trying to use workspace.workspaceFolders
as this gets back the folders. The issue here being it contanins a array of worspace folders. Unsure how you can have multiple workspace folders in vscode so I cant rlly play around with this and see if the array is in some sort of order
https://gyazo.com/77aabefb8508751f752bbfb609912dc8/draw
from vscord.
the problem with this is we need to use the current folder, so we have to figure out how the index affect the array before we use .workspaceFolders
from vscord.
Yea that why I was saying idk how to get multiple workspaces to see if there is some sort of index or order to it
from vscord.
So been thinking about this and poking around the vscode API docs. We can figure out if something is a remote by looking at the remoteName
in the env. If it is not a remote it returns undefined. Thinking that we could encoperate a check around this to get the current file and folders a different way. Unsure atm just writing this here for now. When I get some time will see if I can figure out a good way of doing this
from vscord.
that sounds like a great idea, unfortunately, i am working on a rewrite of config system and it's might for me right now
i will work on it tomorrow after the config system, you can help me by writing the description of each config :P
from vscord.
Happy to help in anyway, not sure what u want me to do wtih the docs if you wanna talk about it more. Explain it here or u can add me on discord if u would like nick22985#1228
from vscord.
should be fixed in dd7e1b6
from vscord.
Related Issues (20)
- HTML Files. HOT 8
- Toggle icon to disable/enable extension HOT 1
- Add support for the Gleam language HOT 5
- Markdown File Reading
- Command `vscord.reconnect` not found HOT 3
- File name not showing correctly HOT 2
- Failed to reconnect to discord gateway [SOLVED]
- Ignore organization does not work HOT 2
- I found a typo in the settings
- Unable to parse Git repositories with `insteadOf` and `pushInsteadOf` URI "rewrites" HOT 6
- Add folder based mappings to the `additionalFileMapping` setting HOT 2
- `.ts` missing for tailwind image
- Hide 'View Repository' button on private repositories
- Jupyter Notebook files not identified HOT 1
- 😭 Icon gruntfile is not appear HOT 1
- Show terminal tab selection HOT 1
- RTC_COULD_NOT_CONNECT HOT 1
- View Repository Button Doesn't Work HOT 9
- add separate option to controll if workspace, filename or git repo should be hidden
- Can't connect to gateway HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vscord.